Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

341: Fix Validation Rule Engine concurrency issues #997

Merged
merged 8 commits into from
Apr 2, 2024
Merged

341: Fix Validation Rule Engine concurrency issues #997

merged 8 commits into from
Apr 2, 2024

Conversation

basiliskus
Copy link
Contributor

@basiliskus basiliskus commented Apr 1, 2024 •
edited
Loading

Fix Validation Rule Engine concurrency issues

  • Fixed concurrency issues when loading rules
  • Fixed validation rule fhirpath for "Message has required receiver id". It was previously matching receiver namespace as well

Issue

#341

Checklist

  • I have added tests to cover my changes
  • I have added logging where useful (with appropriate log level)
  • I have added JavaDocs where required
  • I have updated the documentation accordingly

@basiliskus basiliskus changed the title Fix Validation Rule Engine concurrency issues 341: Fix Validation Rule Engine concurrency issues Apr 2, 2024
@luis-pabon-tf
Update RuleEngine.java
802ca63 
Double checked locking added on ensureRulesLoaded
@luis-pabon-tf
Merge branch 'story/341/fix-concurrency-issue' of https://github.com/…
063f00e 
…CDCgov/trusted-intermediary into story/341/fix-concurrency-issue
@luis-pabon-tf luis-pabon-tf marked this pull request as ready for review April 2, 2024 19:00
@halprin halprin dismissed their stale review April 2, 2024 21:06

Change made, looks awesome.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

halprin
halprin approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@halprin halprin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@basiliskus basiliskus merged commit 40639da into main Apr 2, 2024
15 checks passed
@basiliskus basiliskus deleted the story/341/fix-concurrency-issue branch April 2, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis-pabon-tf luis-pabon-tf luis-pabon-tf left review comments

@halprin halprin halprin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@basiliskus @luis-pabon-tf @halprin