-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse2D version 3 #183
Sparse2D version 3 #183
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #183 +/- ##
===========================================
+ Coverage 61.88% 63.46% +1.57%
===========================================
Files 30 36 +6
Lines 1658 2184 +526
===========================================
+ Hits 1026 1386 +360
- Misses 632 798 +166
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, this put PySAP on better tracks for its installation and usage.
As a more general reflexion I think this PR could also be the occasion to move to a standart pyproject.toml file (which will combine develop.txt, requirements.txt, setup.cfg etc...)
For the CI i recommend to switch to the more general setup-python 1 action, to be more close to the user experience.
Footnotes
-
as recommended by github: https://docs.github.com/en/actions/automating-builds-and-tests/building-and-testing-python ↩
Co-authored-by: Pierre-Antoine Comby <[email protected]>
Co-authored-by: Pierre-Antoine Comby <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Thanks a lot @paquiteau! 🙏 I will need to update the git tag for Sparse2D once I make release over there, but I can do that in a separate PR, before we make a new PySAP release. |
Summary
show
methods will raise an error, methods to be removed in follow-up releasedevelop.txt
with development dependenciesIssues
mr_deconv
in the latest version of Sparse2D, which raises a segementation fault in some cases, the corresponding test has been skipped and an issue has been opened to investigate