Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6주차] Team Buldog 김다희 & 이지인 미션 제출합니다. #15

Open
wants to merge 97 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
97 commits
Select commit Hold shift + click to select a range
d8d1945
feat : 초기 설정
jinnyleeis May 6, 2024
09683ee
Merge pull request #1 from jinnyleeis/master
jinnyleeis May 6, 2024
aeb9628
style : global font
jinnyleeis May 6, 2024
b97d1fb
Merge pull request #2 from jinnyleeis/master
jinnyleeis May 6, 2024
7986c9f
feat : tawilwind css, prettier setting
jinnyleeis May 8, 2024
1d9533d
Merge pull request #3 from jinnyleeis/master
jinnyleeis May 8, 2024
5851f5e
feat: 폰트 적용
Dahn12 May 8, 2024
e2eb310
feat: header 틀 완성
Dahn12 May 9, 2024
7ef2794
feat: navbar, controller 컴포넌트 틀 완성
Dahn12 May 9, 2024
6e108ae
feat: 컴포넌트 파일 생성
Dahn12 May 9, 2024
3d2679a
fix: tailwind 다시 깔았음
Dahn12 May 9, 2024
f51edf3
Revert "fix: tailwind 다시 깔았음"
Dahn12 May 9, 2024
63814cb
fix: tailwind 수정 완료
Dahn12 May 9, 2024
6d912a0
feat : api
jinnyleeis May 10, 2024
da57bd7
Create main.yml
jinnyleeis May 10, 2024
e650847
Update main.yml
jinnyleeis May 10, 2024
884bef0
Update main.yml
jinnyleeis May 10, 2024
6bf832f
Update main.yml
jinnyleeis May 10, 2024
daa4189
Update main.yml
jinnyleeis May 10, 2024
396e052
Update main.yml
jinnyleeis May 10, 2024
acfb4de
Merge pull request #4 from team-Buldok/fixTailwind
jinnyleeis May 10, 2024
87e17b5
update packge.json
jinnyleeis May 10, 2024
e7aa2a6
Update package.json
jinnyleeis May 10, 2024
5ad33e3
Merge branch 'master' of https://github.com/jinnyleeis/next-netflix-19th
jinnyleeis May 10, 2024
c886d0d
.
jinnyleeis May 10, 2024
0a1aae4
feat: Navbar 스타일링
Dahn12 May 10, 2024
e2dd5ed
feat: header 스타일링
Dahn12 May 10, 2024
1a30a03
fear : movie data feching api 구현, 캐러셀 구현
jinnyleeis May 10, 2024
a7fd88f
Merge branch 'jiinlee' into fixTailwind
jinnyleeis May 10, 2024
dcb4dfc
feat : 삭제
jinnyleeis May 10, 2024
5ffe34c
feat: controller 스타일링
Dahn12 May 10, 2024
bdb3f57
Merge branch 'fixTailwind' of https://github.com/team-Buldok/next-net…
Dahn12 May 10, 2024
adbb45b
fix: merge 후 확인
Dahn12 May 10, 2024
d187927
feat: carousel 이미지 변환 구현 완료
Dahn12 May 10, 2024
57a7120
docs: 불필요한 css 파일 삭제
Dahn12 May 10, 2024
e39ed5b
fix: global.css 수정
Dahn12 May 10, 2024
5976212
feat: landing logo 완성
Dahn12 May 10, 2024
a41cdce
feat : Mainlists 컴포넌트 분리
jinnyleeis May 10, 2024
7a3b9f9
fix : carousel 이미지 비율 맞게 채워지도록 수정
Dahn12 May 10, 2024
fd501d1
Merge branch 'fixTailwind' of https://github.com/team-Buldok/next-net…
Dahn12 May 10, 2024
4f9cfc8
fix: mainlists 컴포넌트 이미지 사이즈 수정
Dahn12 May 10, 2024
a4ec9a8
feat: 전체 디자인 수정
Dahn12 May 10, 2024
0f411bf
Merge branch 'fixTailwind'
jinnyleeis May 10, 2024
cc849c6
fix : 배포
jinnyleeis May 10, 2024
f2322d7
delete : 불필요 파일
jinnyleeis May 10, 2024
dbe0149
fix : change next-netflix -> src
jinnyleeis May 10, 2024
4712125
Merge pull request #5 from jinnyleeis/master
jinnyleeis May 10, 2024
ec4083c
fix : 배포
jinnyleeis May 10, 2024
ab092e3
fix : 배포
jinnyleeis May 10, 2024
0c8ed24
feat : preview 원형으로 , 스크롤바 삭제
jinnyleeis May 10, 2024
d170258
refactor : api 기능 정리
jinnyleeis May 10, 2024
3b30736
Merge pull request #6 from jinnyleeis/master
jinnyleeis May 10, 2024
c2846d1
.
jinnyleeis May 10, 2024
bebef4a
Merge branch 'master' of https://github.com/jinnyleeis/next-netflix-19th
jinnyleeis May 10, 2024
800e6f3
fix : 파일 정리, 배포 해결
jinnyleeis May 10, 2024
1582c86
Merge pull request #7 from jinnyleeis/master
jinnyleeis May 11, 2024
201d8e8
fix : 넷플릭스 폰트 적용x 문제 해결
jinnyleeis May 12, 2024
cdfe3b5
Merge pull request #8 from jinnyleeis/master
jinnyleeis May 12, 2024
f33a7a4
docs: package.json 불필요한 파일 삭제
Dahn12 May 12, 2024
007580b
Merge branch 'master' into Dahn12
Dahn12 May 12, 2024
80e6e47
docs: package.json 불필요한 파일 삭제
Dahn12 May 12, 2024
5d19490
feat : detail 동적 페이지, search 페이지 뼈대 추가
jinnyleeis May 15, 2024
c4a23d6
feat : navbar 아이콘 클릭에 따른 -> 페이지 라우팅
jinnyleeis May 15, 2024
48a7c00
feat : current path에 따른, navitem 텍스트 색상 변화
jinnyleeis May 15, 2024
1dbc8e7
feat, fix : navbar 컴포넌트 공용 레이아웃으로 변경
jinnyleeis May 15, 2024
6fb4411
Delete Nav-links.tsx
jinnyleeis May 15, 2024
2d47fc6
Merge pull request #9 from jinnyleeis/master
jinnyleeis May 15, 2024
2573a61
feat. : id에 따른 movie detail 받아오는 api 구현, delete : 불필요 img
jinnyleeis May 15, 2024
a521046
Merge pull request #10 from jinnyleeis/master
jinnyleeis May 15, 2024
63b2d02
Merge branch 'master' into Dahn12
Dahn12 May 16, 2024
5156966
feat : detail 페이지, overview, poster img 추가
jinnyleeis May 16, 2024
d04d2b0
Merge pull request #11 from jinnyleeis/master
jinnyleeis May 16, 2024
68a0df0
feat : 이미지 클릭 시 해당 영화 detail로 이동
jinnyleeis May 16, 2024
bcccd56
Merge pull request #12 from jinnyleeis/master
jinnyleeis May 16, 2024
a6c674d
Merge branch 'master' into Dahn12
Dahn12 May 16, 2024
8ca7a51
feat: searchpage, searchlist 틀잡기(기능, style x)
Dahn12 May 16, 2024
ccc4371
feat: 검색 기능 구현
Dahn12 May 16, 2024
3cd72e9
feat : api 1개로, main 페이지 서버 컴포넌트로 변경
jinnyleeis May 16, 2024
c75a47c
Merge pull request #13 from jinnyleeis/master
jinnyleeis May 16, 2024
80ff729
fix : 검색 시 영화 정보 중복 문제
jinnyleeis May 17, 2024
bc53ab9
feat : http 요청 200번대인 이미지만 필터링하는 checkImage 함수 구현
jinnyleeis May 17, 2024
d0fe966
Merge branch 'team-Buldok:master' into master
jinnyleeis May 17, 2024
09a57f1
Merge pull request #14 from jinnyleeis/master
jinnyleeis May 17, 2024
7b78d60
feat: search page 일부 css
Dahn12 May 17, 2024
9baa23b
Merge branch 'master' into Dahn12
Dahn12 May 17, 2024
6c68820
feat: search page 디자인 완성
Dahn12 May 17, 2024
3b437d3
feat : 미들웨어 추가, 404,403,각종 페이지
jinnyleeis May 17, 2024
90cee50
Merge pull request #15 from jinnyleeis/master
jinnyleeis May 17, 2024
ef70e00
Merge branch 'Dahn12' of https://github.com/team-Buldok/next-netflix-…
Dahn12 May 17, 2024
3a10bd3
feat : 변하는 캐러셀 영화에 맞게, 영화 소개도 업데이트 되도록 수정
jinnyleeis May 17, 2024
276d090
Merge pull request #16 from jinnyleeis/master
jinnyleeis May 17, 2024
dab5391
feat: detailpage 디자인 완성
Dahn12 May 17, 2024
e666e2e
Merge branch 'master' into Dahn12
Dahn12 May 17, 2024
f13a673
feat: image 그라데이션 적용
Dahn12 May 17, 2024
cc2a320
fix: navbar 색상변경
Dahn12 May 17, 2024
c04915f
fix: mainpage 밀림 수정
Dahn12 May 17, 2024
8dc6294
fix: search input focusing 제거
Dahn12 May 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: git push into another repo to deploy to vercel

on:
push:
branches: [master]

jobs:
build:
runs-on: ubuntu-latest
container: pandoc/latex
steps:
- uses: actions/checkout@v3
- name: Install mustache (to update the date)
run: apk add ruby && gem install mustache
- name: Setup Node.js
uses: actions/setup-node@v3
with:
node-version: '20.x' # Ensuring compatibility with Node.js 20
- name: creates output
run: sh ./build.sh
- name: Pushes to another repository
id: push_directory
uses: cpina/github-action-push-to-another-repository@master
env:
API_TOKEN_GITHUB: ${{ secrets.DEPLOY_TOKEN }}
with:
source-directory: 'output'
destination-github-username: jinnyleeis
destination-repository-name: next-netflix-19th-deploy
user-email: ${{ secrets.OFFICIAL_ACCOUNT_EMAIL }}
commit-message: ${{ github.event.commits[0].message }}
target-branch: master
- name: Test get variable exported by push-to-another-repository
run: echo $DESTINATION_CLONED_DIRECTORY
Comment on lines +1 to +34
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

팀 레포에 대한 버셀의 요금 부과 정책에 대비하여 Github Actions를 활용해 개인 레포로 옮긴 것 멋집니다 ㅎㅎ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 자동배포 설정해주셨군요!! 저희도 설정해줬는데 너무 편한 것 같아요

1 change: 1 addition & 0 deletions next-netflix/.next/server/app-paths-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
self.__INTERCEPTION_ROUTE_REWRITE_MANIFEST="[]"
6 changes: 6 additions & 0 deletions next-netflix/.next/server/middleware-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"version": 3,
"middleware": {},
"functions": {},
"sortedMiddleware": []
}
1 change: 1 addition & 0 deletions next-netflix/.next/server/pages-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
1 change: 1 addition & 0 deletions next-netflix/.next/server/server-reference-manifest.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions next-netflix/.next/server/server-reference-manifest.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"node": {},
"edge": {},
"encryptionKey": "qMpyjAhXxmdrHK1j19c0PV7I790xFLpFV8ADrmH4K6o="
}
1 change: 1 addition & 0 deletions next-netflix/.next/types/package.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"type": "module"}
1 change: 1 addition & 0 deletions src/.env
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

환경변수 냠

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.gitignore.env 파일을 입력해서 push를 방지해주시면 될 것 같아요.
저희팀이 이번 과제에서 참고한 글 남길게용

NextJS에서 환경변수 .env 사용하는 방법

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 관련 내용 공부한거 남기고 갑니다!!

  • 타인에게 보여주기 민감한 정보를 담고 있는 .env.local 파일
  • .gitignore에 이 파일이 자동으로 등록되어 있다. 즉 깃허브에 push 해도 .env.local 파일은 올라가지 않는다.
  • .gitignore에 등록되어 있는 파일이기 때문에 깃허브 협업 시 누군가가 .env.local을 작성하고 깃허브에 push해도 다른 팀원들은 확인할 수 없다. 각자 로컬에서 .env.local 파일을 작성해주어야 한다.
  • vercel로 배포 시 vercel은 .gitignore 파일을 적용하지 않기 때문에 .env.local 파일도 적용되지 않는다. 따라서 vercel에서 따로 환경 변수를 등록해주어야 한다. (참고 자료)

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
TMDB_API_KEY=306b2f5b5d2eec206b28b7a4018fef5d
3 changes: 3 additions & 0 deletions src/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"extends": "next/core-web-vitals"
}
36 changes: 36 additions & 0 deletions src/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js
.yarn/install-state.gz

# testing
/coverage

# next.js
/.next/
/out/

# production
/build

# misc
.DS_Store
*.pem

# debug
npm-debug.log*
yarn-debug.log*
yarn-error.log*

# local env files
.env*.local

# vercel
.vercel

# typescript
*.tsbuildinfo
next-env.d.ts
8 changes: 8 additions & 0 deletions src/.prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
module.exports = {
semi: true,
trailingComma: 'all',
singleQuote: true,
printWidth: 100,
tabWidth: 2,
plugins: ['prettier-plugin-tailwindcss'],
};
36 changes: 36 additions & 0 deletions src/README.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
This is a [Next.js](https://nextjs.org/) project bootstrapped with [`create-next-app`](https://github.com/vercel/next.js/tree/canary/packages/create-next-app).

## Getting Started

First, run the development server:

```bash
npm run dev
# or
yarn dev
# or
pnpm dev
# or
bun dev
```

Open [http://localhost:3000](http://localhost:3000) with your browser to see the result.

You can start editing the page by modifying `app/page.tsx`. The page auto-updates as you edit the file.

This project uses [`next/font`](https://nextjs.org/docs/basic-features/font-optimization) to automatically optimize and load Inter, a custom Google Font.

## Learn More

To learn more about Next.js, take a look at the following resources:

- [Next.js Documentation](https://nextjs.org/docs) - learn about Next.js features and API.
- [Learn Next.js](https://nextjs.org/learn) - an interactive Next.js tutorial.

You can check out [the Next.js GitHub repository](https://github.com/vercel/next.js/) - your feedback and contributions are welcome!

## Deploy on Vercel

The easiest way to deploy your Next.js app is to use the [Vercel Platform](https://vercel.com/new?utm_medium=default-template&filter=next.js&utm_source=create-next-app&utm_campaign=create-next-app-readme) from the creators of Next.js.

Check out our [Next.js deployment documentation](https://nextjs.org/docs/deployment) for more details.
32 changes: 32 additions & 0 deletions src/app/api/route.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import { NextRequest, NextResponse } from 'next/server';
import { fetchAllCategories } from '../utils/movieAPI';



export async function GET(request: NextRequest) {
try {
const movies = await fetchAllCategories();
return new NextResponse(JSON.stringify(movies), {

status: 200,
headers: {
'Content-Type': 'application/json',
},
});
} catch (error) {
Comment on lines +7 to +16
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try, catch 도 좋지만 ok 상태(movies.ok)로 api fetching 의 성공 유뮤를 파악한 후 분기처리를 해주는 방법도 좋을 것 같아요 ㅎㅎ

console.error('Error fetching movies:', error);
return new NextResponse(
JSON.stringify({
message: `Failed to fetch data from TMDB.`,
error: (error as Error).message,
}),
{
status: 500,
headers: {
'Content-Type': 'application/json',
},
},
);
}
}

16 changes: 16 additions & 0 deletions src/app/commingSoon/page.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
function CommingSoon() {
return (
<div>
<main>
<h1 className="mt-[300px] flex justify-center text-[150px]">🎁</h1>
<h1 className=" mt-[5px] flex justify-center text-[40.92px] font-bold">
Comming Soon!
</h1>
</main>
</div>
);
}

export default CommingSoon;


Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른 페이지들도 센스 있게 아이콘으로 띄워주시네용 👍

52 changes: 52 additions & 0 deletions src/app/components/Carousel.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
'use client';
import React from 'react';
import Image from 'next/image';
import { Movie } from '../types/movies';

interface CarouselProps {
movies: Movie[];
currentMovieIndex: number;
}

function Carousel({ movies, currentMovieIndex }: CarouselProps) {
return (
<div className="relative mb-[20px] h-[395px] w-[375px] ">
<div className="w-[375px] h-[415px] overflow-hidden relative">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

최외곽 div랑 내부 이미지 감싸는 div가 height이 오타난 것 같아요. 어차피 fill 속성으로 부모 크기에 따라 맞춰지게 지정해주셔서 이미지를 감싸는 div에 따로 width와 height을 지정해주지 않아도 될 것 같아요!

{movies.length > 0 && (
<>
<Image
src={`https://image.tmdb.org/t/p/original${movies[currentMovieIndex].backdrop_path}`}
alt={movies[currentMovieIndex].title}
fill
sizes="100vw"
className="object-cover"
/>
{ /* 그라데이션 */}
<div
style={{
position: 'absolute',
top: 0,
left: 0,
right: 0,
height: '40%',
backgroundImage: 'linear-gradient(to bottom, rgba(0, 0, 0, 0.7), transparent)',
}}
></div>
<div
style={{
position: 'absolute',
bottom: 0,
left: 0,
right: 0,
height: '40%',
backgroundImage: 'linear-gradient(to top, rgba(0, 0, 0, 0.7), transparent)',
}}
Comment on lines +24 to +43
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그라데이션 부분은 따로 컴포넌트로 만들어서 사용해주시면 협업을 할 때 가독성이 좋아질 것 같아요!!

Suggested change
{ /* 그라데이션 */}
<div
style={{
position: 'absolute',
top: 0,
left: 0,
right: 0,
height: '40%',
backgroundImage: 'linear-gradient(to bottom, rgba(0, 0, 0, 0.7), transparent)',
}}
></div>
<div
style={{
position: 'absolute',
bottom: 0,
left: 0,
right: 0,
height: '40%',
backgroundImage: 'linear-gradient(to top, rgba(0, 0, 0, 0.7), transparent)',
}}
<GradientStyle />

></div>
</>
)}
</div>
</div>
);
};

export default Carousel;
52 changes: 52 additions & 0 deletions src/app/components/Controller.tsx

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svg를 불러와서 next/image의 Image의 src에 넣어주는 방법도 좋지만 svg 파일을 컴포넌트처럼 사용할 수 있는 방법이 있더라구요!! 저도 이번에 첨 알았습니다 쓰면서 편하고 좋았어서 한번 참고해보시는거 추천드려요 ㅎㅎ

https://react-svgr.com/docs/next/

Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
'use client';
import React, { useEffect, useState } from 'react';
import Image from 'next/image';
import Top10 from '../../public/icons/top10.svg';
import Plus from '../../public/icons/plus.svg';
import Info from '../../public/icons/info.svg';
import Play from '../../public/icons/play.svg';
import { Movie } from '../types/movies';

interface ControllerProps {
movies: Movie[];
currentMovieIndex: number;
}

function Controller({ movies, currentMovieIndex }: ControllerProps) {
const [rank, setRank] = useState((currentMovieIndex % 10) + 1);

useEffect(() => {
setRank((currentMovieIndex % 10) + 1);
}, [currentMovieIndex]);

const currentMovie = movies[currentMovieIndex];

return (
<div className="mb-[43px] flex w-[375px] flex-col items-center">
<div className="mb-[11px] flex space-x-[5px]">
<Image src={Top10} alt="top10" width={15} height={15} />
{currentMovie && (
<span className="text-cont1 font-bold">
#{rank} {currentMovie.title}
</span>
)}
</div>
<div className="flex space-x-[42px]">
<button className="flex flex-col items-center">
<Image src={Plus} alt="plus" width={24} height={24} />
<span className="text-cont2 font-normal">My List</span>
</button>
<button className="flex h-11 w-28 cursor-pointer items-center justify-center gap-2.5 rounded-md border-none bg-[#C4C4C4]">
<Image src={Play} alt="play" width={18} height={21.6} />
<span className="text-play font-semibold text-[#000000]">Play</span>
Comment on lines +39 to +41
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

자주 사용되는 색깔에 대해서는 쉬운 네이밍으로 세팅하는 게 좋을 것 같아요 ㅎㅎ

https://doyourbestcode.tistory.com/131

제가 Next + Tailwind 를 세팅하는 방식도 살짝 참고만 해보세요~~

</button>
<button className="flex flex-col items-center">
<Image src={Info} alt="info" width={24} height={24} />
<span className="text-cont2 font-normal">Info</span>
</button>
</div>
</div>
);
}

export default Controller;
32 changes: 32 additions & 0 deletions src/app/components/Header.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import Image from 'next/image';
import logo from '../../public/icons/logos_netflix-icon.svg'

function Header() {
const Menu = ['Tv Shows' ,'Movies', 'My List']
Copy link

@wokbjso wokbjso May 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤더 텍스트들을 배열로 관리해주신 덕분에 추후 유지보수에도 좋겠네요 ㅎㅎㅎ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그러게요! 배열로 관리할 생각은 따로 못해봤는데 좋은 방법인 것 같습니다

return (
<div className='fixed top-[24px] flex justify-center items-center w-[375px] h-[57px] z-50'>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어느정도 스크롤 하면 헤더의 background-color를 설정해준다면 스크롤이 내려왔을 때도 헤더가 더 잘 보일 것 같아요!!

<div className='mr-[25px]'>
<Image
src = {logo}
alt='logo'
width={56.67}
height={57}
/>
</div>
<div className='flex space-x-[25px]'>
{
Menu.map((menu) => {
return(
<span className='font-normal text-header'key={menu}>
{menu}
</span>
)
}
)
}
</div>
Comment on lines +16 to +27
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.prettierrc파일은 잘 있는데 indent 사이즈가 설정한 것과 다른것 같아요 ! prettierrc가 잘 적용이 안됐을까요?

</div>
)
}

export default Header
20 changes: 20 additions & 0 deletions src/app/components/LandingLogo.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
"use client";

import { useRouter } from "next/navigation";
import Lottie from "react-lottie-player";
import netflix from "../../public/icons/netflix-landing.json";

const LandingLogo = () => {
const router = useRouter();
return (
<Lottie
animationData={netflix}
style={{ width: "60%" }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

중간중간 이렇게 style을 지정해주신 부분이 있던데 이유가 궁금해요!

play
loop={false}
onComplete={() => router.push("/main")}
/>
);
};

export default LandingLogo;
Loading