Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance development to fix all GitHub Actions (lint, unitTest) errors #5

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

mrtamm
Copy link
Contributor

@mrtamm mrtamm commented Mar 2, 2024

It contains more than hundred changed files but, in general, they can be grouped:

  1. Deprecated APIs:
    • ioutils: use corresponding methods in os or io packages
    • github.com/golang/protobuf/jsonpb -> google.golang.org/protobuf/encoding/protojson
    • github.com/golang/protobuf/proto -> google.golang.org/protobuf/proto
    • google.golang.org/grpc -> google.golang.org/grpc/status
    • due to API changes, had to regenerate ProtoBuf code using protoc
    • due to upgraded Protobuf CLI tools, had to update Makefile
  2. error checking: added more error checks where it was properly done
  3. Due to more specific error checking, unit tests discovered more problems, due to which those tests had to be fixed as well.
  4. Had to upgrade github.com/shirou/gopsutil -> github.com/shirou/gopsutil/v3 as it did not work well on MacOS
  5. Other minor specific deprecated functionality: had to replace with other types/methods
  6. Updated GitHub Actions (tests.yml) to optimise the workflow (removed fixed go versions by referring to go.mod; improved workflow caching thanks to actions/setup-go@v5 which does it by default)
  7. Update direct go dependencies.

@mrtamm mrtamm changed the title Fix lint and unitTest errors Maintenance development to fix all GitHub Actions (lint, unitTest) errors Mar 2, 2024
@xhejtman xhejtman merged commit 568ca5e into CERIT-SC:master Mar 11, 2024
5 checks passed
@mrtamm mrtamm deleted the fix-lint-errors branch March 12, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants