Skip to content

Commit

Permalink
Revert "vcomp/lavc libsvtav1: do not set pred_struct=1"
Browse files Browse the repository at this point in the history
This reverts commit fa8bb8c.

Actually this worsened the behavior significantly by increasing the
latency in the order of 100 frames (depending on properties). This
(currently) disallows setting the bitrate, using CRF/CQP is only possible
because the FFmpeg plugin isn't able to set CBR for now.
  • Loading branch information
MartinPulec committed Jul 9, 2024
1 parent c445c6f commit 6b10300
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/video_compress/libavcodec.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1947,8 +1947,9 @@ static void configure_svt(AVCodecContext *codec_ctx, struct setparam_param *para
check_av_opt_set<const char *>(codec_ctx->priv_data, "preset",
preset);
#if LIBAVCODEC_VERSION_INT > AV_VERSION_INT(59, 21, 100)
//pred-struct=1 is low-latency mode
check_av_opt_set(codec_ctx->priv_data, "svtav1-params",
"fast-decode=1:tile-columns=2:tile-rows=2");
"pred_struct=1:fast-decode=1:tile-columns=2:tile-rows=2");
#else
// tile_columns and tile_rows are log2 values
for (auto const &val : { "tile_columns", "tile_rows" }) {
Expand Down

0 comments on commit 6b10300

Please sign in to comment.