Using type/extension plugins within printed context #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
January 16, 2025 16:13
michalvasko
requested changes
Jan 22, 2025
| if (!record) { | ||
| /* try to find shared plugin */ | ||
| record = lyplg_record_find(NULL, LYPLG_EXTENSION, module, revision, name); | ||
| if (!strncmp(record->plugin.id, "ly2 - ", 6)) { |
There was a problem hiding this comment.
Not a good check, learn this rather by comparing the index with the number of internal plugins, they are always loaded first and their number is a compile-time variable.
| @@ -405,7 +405,7 @@ struct lysp_ext_instance { | |||
| const char *argument; /**< optional value of the extension's argument */ | |||
| LY_VALUE_FORMAT format; /**< prefix format of the extension name/argument (::LY_VALUE_XML is YIN format) */ | |||
| void *prefix_data; /**< format-specific data for prefix resolution (see ly_resolve_prefix()) */ | |||
| struct lyplg_ext *plugin; /**< pointer to the extension plugin, if any */ | |||
| uintptr_t plugin; /**< extension plugin, use ::lysc_get_ext_plugin() */ | |||
There was a problem hiding this comment.
-> use ::lysc_get_ext_plugin() to get the plugin
| ctxp_set(&orig_ctx->modules, &ctx->modules, mem); | ||
| for (i = 0; i < ctx->modules.count; ++i) { | ||
| /* build the address ht */ |
There was a problem hiding this comment.
Better allocate the shared module and store its new address in HT so it can be referenced.
|
|
||
| assert(term->value.realtype && term->value.realtype->plugin && term->value.realtype->plugin->print && | ||
| term->schema); | ||
| assert(term->value.realtype && (type = lysc_get_type_plugin(term->value.realtype->plugin)) && |
There was a problem hiding this comment.
assert is not executed at all in Release build!
| @@ -356,6 +356,7 @@ yprc_extension_instances(struct lys_ypr_ctx *pctx, enum ly_stmt substmt, uint8_t | |||
| { | |||
| LY_ARRAY_COUNT_TYPE u; | |||
| ly_bool inner_flag; | |||
| struct lyplg_ext *ext; | |||
There was a problem hiding this comment.
Rename to ext_plg at least.
| @@ -933,7 +933,7 @@ struct utest_context { | |||
| * @param[in] CANNONICAL_VAL expected cannonical value | |||
| */ | |||
| #define CHECK_LYD_VALUE_EMPTY(NODE, CANNONICAL_VAL) \ | |||
| assert_non_null((NODE).realtype->plugin->print(UTEST_LYCTX, &(NODE), LY_VALUE_CANON, NULL, NULL, NULL)); \ | |||
| assert_non_null(lysc_get_type_plugin((NODE).realtype->plugin)->print(UTEST_LYCTX, &(NODE), LY_VALUE_CANON, NULL, NULL, NULL)); \ | |||
There was a problem hiding this comment.
The canonical value can be retrieved simply by calling lyd_get_value() on NODE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Numerous other smaller changes included, including widening ctx opts from 16 to 32-bits and adding a new flag for
ly_ctx_new.