-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove conda from ci-tests #283
Conversation
🦙 MegaLinter status:
|
Descriptor | Linter | Files | Fixed | Errors | Elapsed time |
---|---|---|---|---|---|
black | 29 | 1 | 1.31s | ||
✅ PYTHON | pylint | 29 | 0 | 4.58s |
See detailed report in MegaLinter reports
b3249a9
to
7b60669
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
==========================================
- Coverage 95.60% 95.60% -0.01%
==========================================
Files 22 22
Lines 1525 1524 -1
==========================================
- Hits 1458 1457 -1
Misses 67 67 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Chosen to remove Conda rather than fix it. I think our GH Action should use as many inbuilt features as possible and not introduce dependencies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments below
.github/workflows/ci-tests.yaml
Outdated
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python }} | ||
- name: Install dependencies | ||
run: | | ||
python --version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@christopher-wild This isn't doing what it should be doing. Have a look at the output logs for e.g. Python 3.10 on Mac OS. Under install dependencies / test with PyTest, it's running the wrong version of python (3.12 in this case even though 3.10 is requested from actions/setup-python@v5
.
Their docs say:
The python-version input is optional. If not supplied, the action will try to resolve the version from the default .python-version file. If the .python-version file doesn't exist Python or PyPy version from the PATH will be used. The default version of Python or PyPy in PATH varies between runners and can be changed unexpectedly so we recommend always setting Python version explicitly using the python-version or python-version-file inputs.
So it might be a simple fix by just changing python-version: ${{ matrix.python }}
to python-version: ${{ matrix.python-version }}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
No description provided.