Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conda from ci-tests #283

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Remove conda from ci-tests #283

merged 3 commits into from
Jul 16, 2024

Conversation

christopher-wild
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Jul 10, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
⚠️ PYTHON black 29 1 1.31s
✅ PYTHON pylint 29 0 4.58s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (d74e853) to head (837b1ce).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #283      +/-   ##
==========================================
- Coverage   95.60%   95.60%   -0.01%     
==========================================
  Files          22       22              
  Lines        1525     1524       -1     
==========================================
- Hits         1458     1457       -1     
  Misses         67       67              

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a86d9c...837b1ce. Read the comment docs.

@christopher-wild christopher-wild linked an issue Jul 11, 2024 that may be closed by this pull request
@christopher-wild
Copy link
Contributor Author

Chosen to remove Conda rather than fix it. I think our GH Action should use as many inbuilt features as possible and not introduce dependencies.

Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments below

Comment on lines 25 to 30
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python }}
- name: Install dependencies
run: |
python --version
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@christopher-wild This isn't doing what it should be doing. Have a look at the output logs for e.g. Python 3.10 on Mac OS. Under install dependencies / test with PyTest, it's running the wrong version of python (3.12 in this case even though 3.10 is requested from actions/setup-python@v5.

Their docs say:

The python-version input is optional. If not supplied, the action will try to resolve the version from the default .python-version file. If the .python-version file doesn't exist Python or PyPy version from the PATH will be used. The default version of Python or PyPy in PATH varies between runners and can be changed unexpectedly so we recommend always setting Python version explicitly using the python-version or python-version-file inputs.

So it might be a simple fix by just changing python-version: ${{ matrix.python }} to python-version: ${{ matrix.python-version }}

Copy link
Contributor

@f-allian f-allian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@christopher-wild christopher-wild merged commit c210ae6 into main Jul 16, 2024
16 checks passed
@christopher-wild christopher-wild deleted the workflow_fixes branch July 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conda no longer works on CI tests
2 participants