BCDA-7655: Update SSAS for resiliency / connection management improvements. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-dzeda
requested review from
kyeah,
karinamzalez and
laurenkrugen-navapbc
|
|
Sure thing, adding @gsf as well for a quick look-see. |
kyeah
approved these changes
Jan 2, 2024
| @@ -31,9 +31,10 @@ func createDB() (*gorm.DB, error) { | |||
|
|
|||
| // TODO: Allow connection settings to be configured by env vars | |||
| // https://jira.cms.gov/browse/BCDA-7109 | |||
| sqlDB.SetMaxOpenConns(40) | |||
| sqlDB.SetMaxOpenConns(60) | |||
There was a problem hiding this comment.
For reference, I checked production and the database-level max connections is pretty high:
bcda=> show max_connections;
max_connections
-----------------
1709
| sqlDB.SetMaxIdleConns(40) | ||
| sqlDB.SetConnMaxLifetime(time.Duration(5) * time.Minute) | ||
| sqlDB.SetConnMaxIdleTime(time.Duration(30) * time.Second) |
There was a problem hiding this comment.
Didn't realize this was a method, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-7655
🛠 Changes
Updated maximum number of DB connections from 40 -> 60
Added idle connection timeout
Updated from go 1.18-> 1.19 concurrent with updating to latest versions of dependencies.
Removed ioutil references (deprecation caused issues going from 1.18-> 1.19)
ℹ️ Context for reviewers
There are inefficiencies in connection handling for the go postgres / sql libraries that we use, leading to issues with stability. While bcda-app is locked to an old version of pgx due to the queuing package used, there’s no such restriction for SSAS, so we can use the latest version of the packages (with connection pooling improvements).
✅ Acceptance Validation
Manual verification of information in the commit, unit tests pass.
🔒 Security Implications
If any security implications apply, add Jason Ashbaugh (GitHub username: StewGoin) as a reviewer and do not merge this PR without his approval.