BFD-3881: IDR beneficiary model updates #2566
Open
+562
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschey-forpeople
requested review from
mjburling,
dondevun and
malessi
as code owners
| CREATE TABLE idr.beneficiary( | ||
| bene_sk BIGINT NOT NULL PRIMARY KEY, | ||
| bene_xref_efctv_sk BIGINT NOT NULL, | ||
| bene_xref_efctv_sk_computed BIGINT NOT NULL GENERATED ALWAYS |
There was a problem hiding this comment.
There's some weird behavior with bene_xref_efctv_sk that causes the potential need for this column. Sometimes that field is set to 0 in which case we need to fall back to using bene_sk for joins. Joining on a case statement is very bad for performance, so computing this value ahead of time will make it possible to filter on these values. This requirement may change as we learn more.
| last_timestamp TIMESTAMPTZ NOT NULL | ||
| ); | ||
|
|
||
| CREATE MATERIALIZED VIEW idr.overshare_mbis AS |
There was a problem hiding this comment.
There is exactly 1 instance in IDR where an MBI is assigned to more than one person. This is an extreme edge case, but we should still do our best to protect against overshares, so we can store these in a way that makes them easy to filter out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA Ticket:
BFD-3881
What Does This PR Do?
What Should Reviewers Watch For?
If you're reviewing this PR, please check for these things in particular:
What Security Implications Does This PR Have?
Please indicate if this PR does any of the following:
Adds any new software dependencies
Modifies any security controls
Adds new transmission or storage of data
Any other changes that could possibly affect security?
I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (
@sb-benohe) approval.)I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.
Validation
Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.
Unit/integration tests