Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BFD-3917: Enable Secure EFT Bucket Access for ISP #2569

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

malessi
Copy link
Contributor

@malessi malessi commented Feb 27, 2025

JIRA Ticket:
BFD-3917

What Does This PR Do?

This PR introduces new IAM resources allowing ISP to push files to BCDA via the prod EFT S3 Bucket.

What Should Reviewers Watch For?

If you're reviewing this PR, please check for these things in particular:

What Security Implications Does This PR Have?

Please indicate if this PR does any of the following:

  • Adds any new software dependencies

  • Modifies any security controls

  • Adds new transmission or storage of data

  • Any other changes that could possibly affect security?

  • I have considered the above security implications as it relates to this PR. (If one or more of the above apply, it cannot be merged without the ISSO or team security engineer's (@sb-benohe) approval.)

  • I have created tests to sufficiently ensure the reliability of my code, if applicable. If this is a modification to an existing piece of code, I have audited the associated tests to ensure everything works as expected.

Validation

Have you fully verified and tested these changes? Is the acceptance criteria met? Please provide reproducible testing instructions, code snippets, or screenshots as applicable.

  • terraform applying these changes to prod eft, verifying that:
    • No errors or unexpected changes were made
    • ISP was able to assume the Role and was able to push a test file to the BCDA path

@malessi malessi marked this pull request as ready for review February 27, 2025 22:32
@malessi malessi enabled auto-merge (squash) February 27, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants