Detect schema version #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schema version is now an optional argument rather than a required argument. If schema version is not provided, look for a version property in the data file. If found, try to use it as if it were the argument value. If not found, log an error and exit. If schema version is provided, still look for a version property in the data file. If it does not match the provided version, log a warning. The provided version is always used when available.
In cases where the version is the last property in the file, a backwards search can get the version quickly. Set a three-second time limit for the searches. If the time limit is reached, consider the version to be unknown.
| }); | ||
| if (lastStuff.bytesRead > 0) { | ||
| const lastText = lastStuff.buffer.toString('utf-8'); | ||
| const versionRegex = /"version"\s*:\s*("(?:\\"|\\\\|[^"])*")/; |
There was a problem hiding this comment.
verified this on an online regex tester.
src/SchemaManager.ts
Outdated
| try { | ||
| const stats = await fileHandle.stat(); | ||
| const lastStuff = await fileHandle.read({ | ||
| position: Math.max(0, stats.size - 100), |
There was a problem hiding this comment.
Is this looking at the last 100 characters? Though a bit arbitrary, I'd be fine 10x that as a "just in case". It shouldn't impact the speed.
Potential edge case, what if the file is smaller than the amount of characters being checked?
There was a problem hiding this comment.
If the file is shorter than the specified length, read will go until the end of the file. It doesn't cause any errors to occur.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #92.
Schema version is now an optional argument rather than a required argument. If schema version is not provided, look for a version property in the data file. If found, try to use it as if it were the argument value. If not found, log an error and exit. If schema version is provided, still look for a version property in the data file. If it does not match the provided version, log a warning. The provided version is always used when available.
This is a significant change to the usage of the command-line interface. When this feature is released, be sure to make that fact very clear in the release notes.