-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring code in src/middleware/render.js to Reduce Cognitive Complexity from 16 to 15 #489
Open
vickyc2266
wants to merge
25
commits into
CMU-313:f24
Choose a base branch
from
vickyc2266:renderMethod-refactor
base: f24
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s 71 with the checkHeadersSent(res) helper method to reduce cognitive complexity
… for visibility of coder
…ew code or checkHeadersSent function
…oes) and saw that the coverage displayed increased coverage in lines and function compared to previously
… gave error saying VICKY_CHEN Not defined
…e original code just to see if it'll work and pass test cases now
Pull Request Test Coverage Report for Build 10722278560Details
💛 - Coveralls |
…e running successfully
Quality Gate passedIssues Measures |
vickyc2266
changed the title
Render method refactor
Refactoring code in src/middleware/render.js
Sep 5, 2024
vickyc2266
changed the title
Refactoring code in src/middleware/render.js
Refactoring code in src/middleware/render.js to Reduce Cognitive Complexity from 16 to 15
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduced cognitive complexity of the renderMethod which is within the processRender function of the render.js file by taking away a conditional that appears in the code more than once and putting it into a helper function with an intuitive title called checkHeadersSent(res). The function here is supposed to provide the same exact logic as the original code but just putting it in into a function and calling that function where it is needed.
resolves #340
UI Test