Refactored Code in public/src/admin/extend/widgets.js #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request Test Coverage Report for Build 10740415697Details
💛 - Coveralls |
|
The existing testing framework does not test the file I have chosen. Since it does not include tests similar to what my code needs to be tested, and we are not allowed to create our own testing framework, I have manually tested out my code. I did this by using the UI to perform tasks (tasks executed by the code in the file) and printed out statements to the console. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #554, with the following sonar cloud warning: https://sonarcloud.io/project/issues?open=AZHAkAeb1341_VbvRHcj&id=dhanya-cmu_NodeBB
The code was refactored to not nest functions more than 4 levels deep. This was done by splitting up the problematic function and moving it outside the body of a main function.