Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

US2 - Ensure that anonymous posts are displayed annonymously #45

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

shantinghou
Copy link

@shantinghou shantinghou commented Sep 23, 2024

What

Ensure that anonymous posts are displayed anonymously both on categories page and topics page.

Why

Complete issue 3 for user story 2. close #15. This feature completes the full flow of making anonymous posts on the nodebb site.

How

Changes were made in both front-end and backend to read topics and posts data. An anonymous profile was added to easily construct the profile in the frontend whenever anonymous was set to true.

Schema Changes

The schema for posts and topics were updated as I added a IsAnonymous field to the structs so that I could pass information on whether a post was anonymous while still tying the post to the user.

Displaying user profile (Front-end)

The public/src/modules/helpers.common.js file was modified as that is where the logic for displaying user profiles are handled. Therefore, the function buildAvatar now takes in additional, optional fields that will indicate whether the avatar should be anonymous or not.
As a result, node_modules/nodebb-theme-harmony/templates/partials/topics_list.tpl and node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl front-end files were modified to take in the additional fields.

Testing

No testing were made yet other than from testing the front end locally and via logs.

Screenshots

Works on both category pages (for topics) and topic pages
Screenshot 2024-09-23 at 3 53 11 PM

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11016864107

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 14 (78.57%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 82.674%

Changes Missing Coverage Covered Lines Changed/Added Lines %
public/src/modules/helpers.common.js 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
src/meta/errors.js 1 76.74%
Totals Coverage Status
Change from base Build 10985466755: -0.01%
Covered Lines: 22337
Relevant Lines: 25596

💛 - Coveralls

Copy link

@guanjiecheng guanjiecheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guanjiecheng guanjiecheng merged commit 9ad2369 into f24 Sep 24, 2024
1 check passed
@shantinghou shantinghou self-assigned this Oct 6, 2024
@shantinghou shantinghou added the enhancement New feature or request label Oct 6, 2024
@shantinghou shantinghou changed the title Us2/addcheckboxannonymous - Ensure that annonymous posts are displayed annonymously Us2 - Ensure that anonymous posts are displayed annonymously Oct 6, 2024
@shantinghou shantinghou changed the title Us2 - Ensure that anonymous posts are displayed annonymously US2 - Ensure that anonymous posts are displayed annonymously Oct 6, 2024
@shantinghou shantinghou modified the milestones: Sprint 1, Sprint 2 Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anonymous enhancement New feature or request
Projects
None yet
4 participants