forked from CMU-313/cmu-313-f24-nodebb-f24-NodeBB
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
US2 - Ensure that anonymous posts are displayed annonymously #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11016864107Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
guanjiecheng
approved these changes
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
shantinghou
changed the title
Us2/addcheckboxannonymous - Ensure that annonymous posts are displayed annonymously
Us2 - Ensure that anonymous posts are displayed annonymously
Oct 6, 2024
shantinghou
changed the title
Us2 - Ensure that anonymous posts are displayed annonymously
US2 - Ensure that anonymous posts are displayed annonymously
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Ensure that anonymous posts are displayed anonymously both on categories page and topics page.
Why
Complete issue 3 for user story 2. close #15. This feature completes the full flow of making anonymous posts on the nodebb site.
How
Changes were made in both front-end and backend to read topics and posts data. An anonymous profile was added to easily construct the profile in the frontend whenever anonymous was set to true.
Schema Changes
The schema for posts and topics were updated as I added a IsAnonymous field to the structs so that I could pass information on whether a post was anonymous while still tying the post to the user.
Displaying user profile (Front-end)
The public/src/modules/helpers.common.js file was modified as that is where the logic for displaying user profiles are handled. Therefore, the function buildAvatar now takes in additional, optional fields that will indicate whether the avatar should be anonymous or not.
As a result, node_modules/nodebb-theme-harmony/templates/partials/topics_list.tpl and node_modules/nodebb-theme-harmony/templates/partials/topic/post.tpl front-end files were modified to take in the additional fields.
Testing
No testing were made yet other than from testing the front end locally and via logs.
Screenshots
Works on both category pages (for topics) and topic pages