Completed The Tasks!!! #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+134
to
+137
| sum=0.0 | ||
| for i in range(len(bookratings)): | ||
| sum=sum+bookratings[i].rating | ||
| book.rating=round((float)(sum/len(bookratings)), 1) |
There was a problem hiding this comment.
This is correct but a more clean and Django-ish way for this could be (with looping):
book.rating = BookRating.objects.filter(book__pk=book_id).aggregate(Avg('rating'))['rating__avg']There was a problem hiding this comment.
Ok I'll make sure to use these functions from next time.
| book = models.ForeignKey(Book, on_delete=models.CASCADE) | ||
| rater = models.CharField(max_length=122) | ||
| rated = models.BooleanField(default = False) | ||
| rating = models.SmallIntegerField(default=0) |
There was a problem hiding this comment.
You can also use MinValueValidator, `MaxValueValidator on this field to have database level rules for it.
There was a problem hiding this comment.
Ok I'll take care of this from now onwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSoC Task 2 Submission
I have completed the following tasks