Define AST without inheriting Namespace #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At an early stage, the top level was defined by a toplevel namespace.
However the specification/examples treats the top level slightly differently.
In the meantime, some of the code was tested by treating Namespace to top level node instead of the AST type and (in quite a sloppy way) just achieving that by inheriting Namespace.
This commit is an old fix that should have been pushed a long time ago. It brings things into order by clearly defining the file top-level (represented by the AST class) as an independent thing.
From here, we are back in sync with the current formal specification, and we can from there proceed to make slight modifications - such as clarifying where the versioning should occur (it should be applied to an Interface, not on "file" level) and other quality improvements.