Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Update all setup/installation instructions #33

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

gunnarx
Copy link
Collaborator

@gunnarx gunnarx commented Aug 22, 2022

Additional updates. We have a lot of different ways to install now. I had been using pyenv but recently Mikhail added python -m venv venv, which is yet another thing, not identical to pyenv as I understand it.

So, maybe there are too many ways now but I think this README at least documents them.

I also deprecated pipenv method until we get a setup that seems to work correctly.

@gunnarx
Copy link
Collaborator Author

gunnarx commented Aug 22, 2022

(Look here to view the document with formatting.)

@gunnarx gunnarx requested a review from miketsukerman August 22, 2022 18:58
[global]
target=C:\SomeDir\Where\Your\Account\Can\Write\To
```sh
python3 -m venv venv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the same way as for pipenv local we need to add here source venv/bin/activate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Collaborator

@miketsukerman miketsukerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GitHub actions has to be updated to use python 3.10.6

@gunnarx
Copy link
Collaborator Author

gunnarx commented Aug 26, 2022

I think GitHub actions has to be updated to use python 3.10.6

Yeah, I already added a559637 in #31 for that. Since this is just a README change I did not bother to include it.
EDIT: OK I cherry picked it now

@gunnarx gunnarx force-pushed the readme_update_setup_instructions branch from 6d31cf7 to 6776a8a Compare August 26, 2022 09:43
@gunnarx
Copy link
Collaborator Author

gunnarx commented Aug 26, 2022

I guess the same way as for pipenv local we need to add here source venv/bin/activate.

Added.

@gunnarx gunnarx force-pushed the readme_update_setup_instructions branch 3 times, most recently from 0fd6548 to 945560f Compare September 7, 2022 14:03
@gunnarx gunnarx force-pushed the readme_update_setup_instructions branch from 945560f to b1a621f Compare September 21, 2022 14:02
@gunnarx
Copy link
Collaborator Author

gunnarx commented Sep 21, 2022

Rebased on master because #32 has been merged

@erikbosch
Copy link
Contributor

Meeting decision to merge

@gunnarx gunnarx merged commit 6e1b25b into COVESA:master Sep 26, 2022
@gunnarx gunnarx deleted the readme_update_setup_instructions branch August 4, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants