Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent tagging support added #317

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Consent tagging support added #317

merged 2 commits into from
Dec 12, 2023

Conversation

UlfBj
Copy link
Contributor

@UlfBj UlfBj commented Dec 5, 2023

No description provided.

Signed-off-by: Ulf Bjorkengren <[email protected]>
Copy link
Collaborator

@erikbosch erikbosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I am no user of the binary exporter.

Signed-off-by: Ulf Bjorkengren <[email protected]>
@UlfBj
Copy link
Contributor Author

UlfBj commented Dec 5, 2023

This is a modification of the Go and C parsers only, the binary exporter code is untouched.
Thanks for the review approval.
A merge follow-up would be even more appreciated :)

@erikbosch
Copy link
Collaborator

@adobekan - I suggest that you decide if this one can be merged on the VSS meeting tomorrow.
My view is - There are no known users of the binary feature except Ulf, so no reason to have it open longer unless someone else states that they want more time for review

@adobekan
Copy link
Collaborator

12/12 meeting

  • Ulf: binary is untouched.
    Decision to merge.

@adobekan adobekan merged commit c478a80 into COVESA:master Dec 12, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants