Give better error if unexpected Yaml format #419
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to give a somewhat better error handling for the scenario when your Yaml/vspec file does not have intended indentation.
Example use case:
Which better should be:
As of today you get a cryptic exception. With this you still get exception, but a somewhat easier to understand
vss_tools.tree.InvalidInputFormatException: Node 'A' expected to have a list as child
@UlfBj - this addresses one of the other problems you experienced
@sschleemilch - I believe showing a stack trace to the user here does not help much, but we do not catch other exceptions like
MultipleRootsException
either, but maybe we should. Catch all user-defined exceptions higher up?