Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/schedule editor add eslint #99

Merged
merged 6 commits into from
Dec 14, 2018
Merged

Feature/schedule editor add eslint #99

merged 6 commits into from
Dec 14, 2018

Conversation

yabuta
Copy link
Collaborator

@yabuta yabuta commented Dec 11, 2018

ベーシックなeslintを追加

相談：
これってeslint --fixってやったほうがいいんでしょうか？

@yabuta
Copy link
Collaborator Author

yabuta commented Dec 12, 2018

eslintを全コードに適用
自動修正以外で対応したのは以下の点
・propTypesを指定しろと言われたのでpropsを使ってるクラス全てにpropsTypeを追加

その他：
createRouteCodeTabs.jsのエラーは別ブランチで対応するため放置
App.jsのWP_BASE_HREFは直し方がわからなかったので一旦放置

@morimoto4
Copy link
Collaborator

lgtm!

@morimoto4 morimoto4 merged commit 3ae372d into feature/schedule_editor Dec 14, 2018
@yabuta yabuta deleted the feature/schedule_editor_add_eslint branch December 21, 2018 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiro-ya-iv hiro-ya-iv Awaiting requested review from hiro-ya-iv

@morimoto4 morimoto4 Awaiting requested review from morimoto4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yabuta @morimoto4