Fix articulations/ornaments/technical default value #433
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when parsing a XML score, a note without any articulation, ornament, or technical notation returns an empty dict when accessing those attributes. However, when there are such articulations (or ornaments or technical notations), then accessing the attributes returns a list and no longer a dict.
This is due to the functions
get_articulations
,get_ornaments
andget_technical_notations
all returning lists, but when there is no<notation>
, then the parser sets them to{}
.This PR simply set the default value to an empty list rather than an empty dict for consistency.
I don't think this could cause any issues, let me know if it does.