Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix articulations/ornaments/technical default value #433

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

leleogere
Copy link
Collaborator

@leleogere leleogere commented Feb 26, 2025

Currently, when parsing a XML score, a note without any articulation, ornament, or technical notation returns an empty dict when accessing those attributes. However, when there are such articulations (or ornaments or technical notations), then accessing the attributes returns a list and no longer a dict.

This is due to the functions get_articulations, get_ornaments and get_technical_notations all returning lists, but when there is no <notation>, then the parser sets them to {}.

This PR simply set the default value to an empty list rather than an empty dict for consistency.

I don't think this could cause any issues, let me know if it does.

@leleogere leleogere requested a review from manoskary February 26, 2025 15:46
@leleogere leleogere self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant