chore!: Update to portgraph 0.13 / petgraph 0.7
#1878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1878 +/- ##
=======================================
Coverage 86.55% 86.55%
=======================================
Files 195 195
Lines 35569 35584 +15
Branches 32382 32397 +15
=======================================
+ Hits 30786 30801 +15
Misses 3011 3011
Partials 1772 1772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
aborgna-q
commented
Jan 20, 2025
| @@ -247,7 +247,7 @@ pub(super) mod test { | |||
| Some(Signature::new(vec![usize_t()], vec![usize_t()])) | |||
| ); | |||
| assert_eq!(inner_region.node_count(), 3); | |||
| assert_eq!(inner_region.edge_count(), 2); | |||
| assert_eq!(inner_region.edge_count(), 1); | |||
There was a problem hiding this comment.
This was previously wrong. The inner subgraph is just a DFG with one input / output connected directly to each other.
aborgna-q
force-pushed
the
ab/update-portgraph
branch
from
21252e1 to
8853214
Compare
mark-koch
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new portgraph release comes with some perf improvements.
We require this update for #1869.
Closes #1872.
I added a benchmark variation for subgraphs with few nodes as a drive-by.
This got improved by the new portgraph (skipping a full graph traversal), but the runtime is still mostly the
O(n)full-graph traversal required for the convexity checking when building the subgraph.BREAKING CHANGE: Bumped public dependency
portgraphto breaking version0.13.