-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Exporting converging control flow edges #1890
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1890 +/- ##
==========================================
+ Coverage 86.55% 86.56% +0.01%
==========================================
Files 195 195
Lines 35693 35724 +31
Branches 32506 32537 +31
==========================================
+ Hits 30895 30926 +31
Misses 3011 3011
Partials 1787 1787
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test that fails without this fix.
Constructing the links struct looks like it adds a non-trivial amount of pre-computation. Do you have a measure of performance impact?
(block [%6] [%3 %9] | ||
(block [%6] [%3 %6] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this change make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is a test that should have failed but I overlooked it earlier. It's correct now. So this is the test you asked for.
I measured the performance impact and it was very small.
Fixes #1889.