Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exporting converging control flow edges #1890

Merged
merged 2 commits into from
Jan 25, 2025
Merged

Conversation

zrho
Copy link
Contributor

@zrho zrho commented Jan 22, 2025

Fixes #1889.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.56%. Comparing base (f7eab22) to head (db02256).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   86.55%   86.56%   +0.01%     
==========================================
  Files         195      195              
  Lines       35693    35724      +31     
  Branches    32506    32537      +31     
==========================================
+ Hits        30895    30926      +31     
  Misses       3011     3011              
  Partials     1787     1787              
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 86.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zrho zrho marked this pull request as ready for review January 22, 2025 15:17
@zrho zrho requested a review from a team as a code owner January 22, 2025 15:17
@zrho zrho requested a review from ss2165 January 22, 2025 15:17
Copy link
Member

@ss2165 ss2165 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that fails without this fix.

Constructing the links struct looks like it adds a non-trivial amount of pre-computation. Do you have a measure of performance impact?

(block [%6] [%3 %9]
(block [%6] [%3 %6]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change make sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is a test that should have failed but I overlooked it earlier. It's correct now. So this is the test you asked for.

I measured the performance impact and it was very small.

@zrho zrho added this pull request to the merge queue Jan 25, 2025
Merged via the queue into main with commit ae57f7c Jan 25, 2025
23 checks passed
@zrho zrho deleted the zrho/fix-export-links branch January 25, 2025 21:04
@hugrbot hugrbot mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export does not correctly handle converging control flow edges
2 participants