Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simplify hugr-model #1893

Merged
merged 4 commits into from
Feb 4, 2025

Remove spurious default feature. Also add TODO to comment.

c9e53cc
Select commit
Loading
Failed to load commit list.
Merged

feat: Simplify hugr-model #1893

Remove spurious default feature. Also add TODO to comment.
c9e53cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 4, 2025 in 1s

86.70% (+0.14%) compared to d6b8681

View this Pull Request on Codecov

86.70% (+0.14%) compared to d6b8681

Details

Codecov Report

Attention: Patch coverage is 64.02116% with 272 lines in your changes missing coverage. Please review.

Project coverage is 86.70%. Comparing base (d6b8681) to head (c9e53cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
hugr-core/src/import.rs 52.28% 102 Missing and 96 partials ⚠️
hugr-model/src/v0/text/print.rs 60.00% 5 Missing and 19 partials ⚠️
hugr-model/src/v0/text/parse.rs 68.42% 3 Missing and 15 partials ⚠️
hugr-core/src/export.rs 88.33% 14 Missing ⚠️
hugr-model/src/v0/binary/read.rs 74.50% 2 Missing and 11 partials ⚠️
hugr-model/src/v0/mod.rs 50.00% 3 Missing ⚠️
hugr-model/src/v0/binary/write.rs 95.74% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1893      +/-   ##
==========================================
+ Coverage   86.56%   86.70%   +0.14%     
==========================================
  Files         195      195              
  Lines       35724    35538     -186     
  Branches    32537    32351     -186     
==========================================
- Hits        30925    30814     -111     
+ Misses       3012     2951      -61     
+ Partials     1787     1773      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.