Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not require capnp to be installed to compile hugr-model #1907

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Feb 4, 2025

Now we do the same as with the schema and extensions definition; provide a just command to update it manually and check on CI that things are up-to-date.

This lets us remove the build.rs from hugr-model, removing the need for users to have capnproto installed to compile our crates.

Closes #1667

@aborgna-q aborgna-q requested a review from zrho February 4, 2025 17:37
@aborgna-q aborgna-q requested a review from a team as a code owner February 4, 2025 17:37
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.75%. Comparing base (7312c62) to head (415975a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1907      +/-   ##
==========================================
- Coverage   86.63%   81.75%   -4.88%     
==========================================
  Files         195      196       +1     
  Lines       35777    38962    +3185     
  Branches    32590    35775    +3185     
==========================================
+ Hits        30995    31853     +858     
- Misses       2987     5300    +2313     
- Partials     1795     1809      +14     
Flag Coverage Δ
python 92.34% <ø> (ø)
rust 80.81% <ø> (-5.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(model): standalone py/rust packages for capnproto generated code
1 participant