reject incomplete registers in pytket to qasm conv (#1656)

* reject incomplete registers in pytket to qasm conv * fix spelling * Update pytket/pytket/qasm/qasm.py Co-authored-by: Alec Edgington <[email protected]> * suggestion --------- Co-authored-by: Alec Edgington <[email protected]>
CQCL · Nov 5, 2024 · e46c00a · e46c00a
1 parent 37d9a9c
commit e46c00a
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 0 deletions.
diff --git a/pytket/docs/changelog.rst b/pytket/docs/changelog.rst
@@ -16,6 +16,7 @@ Fixes:
 * Support converting conditional `RangePredicate`s to QASM.
 * Fix `maxwidth` parameter of `circuit_from_qasm_str`
 * Add `scratch_reg_resize_pass` to `circuit_from_qasm_str`
+* Reject incompete classical registers in pytket to qasm conversion
 
 1.34.0 (October 2024)
 ---------------------

diff --git a/pytket/pytket/qasm/qasm.py b/pytket/pytket/qasm/qasm.py
@@ -1142,6 +1142,12 @@ def check_can_convert_circuit(circ: Circuit, header: str, maxwidth: int) -> None
             f"Circuit contains a classical register larger than {maxwidth}: try "
             "setting the `maxwidth` parameter to a higher value."
         )
+    set_circ_register = set([creg.name for creg in circ.c_registers])
+    for b in circ.bits:
+        if b.reg_name not in set_circ_register:
+            raise QASMUnsupportedError(
+                f"Circuit contains an invalid classical register {b.reg_name}."
+            )
     # Empty CustomGates should have been removed by DecomposeBoxes().
     for cmd in circ:
         assert not is_empty_customgate(cmd.op)

diff --git a/pytket/tests/qasm_test.py b/pytket/tests/qasm_test.py
@@ -114,6 +114,16 @@ def test_long_registers_2() -> None:
         assert creg.size <= 100
 
 
+def test_incompete_registers() -> None:
+    c = Circuit(1)
+    c.add_bit(Bit("d", 1))
+    c.add_bit(Bit("d", 2))
+    c.Measure(Qubit(0), Bit("d", 1))
+    with pytest.raises(QASMUnsupportedError) as errorinfo:
+        circuit_to_qasm_str(c, header="hqslib1")
+    assert "Circuit contains an invalid classical register d." in str(errorinfo.value)
+
+
 def test_qasm_qubit() -> None:
     with pytest.raises(RuntimeError) as errorinfo:
         fname = str(curr_file_path / "qasm_test_files/test2.qasm")
@@ -240,6 +250,9 @@ def test_conditional_gates() -> None:
 
 def test_named_conditional_barrier() -> None:
     circ = Circuit(2, 2)
+    circ.add_bit(Bit("test", 0))
+    circ.add_bit(Bit("test", 1))
+    circ.add_bit(Bit("test", 2))
     circ.add_bit(Bit("test", 3))
     circ.Z(0, condition_bits=[0, 1], condition_value=2)
     circ.add_conditional_barrier(