add conditional parameter to gate counting #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cqc-alec
reviewed
Nov 8, 2024
| @@ -1119,6 +1119,7 @@ class Circuit { | |||
| std::map<OpType, unsigned> op_counts() const; | |||
|
|
|||
| unsigned count_gates(const OpType &op_type) const; | |||
| unsigned count_gates_conditional(const OpType &op_type) const; | |||
There was a problem hiding this comment.
I think we should just add an optional argument to count_gates() to make it count conditionals as well.
| "type: The operation type to search for\n:return: the " | ||
| "number of operations matching `type`", | ||
| py::arg("type")) | ||
| "type: The operation type to search for\n:param " |
There was a problem hiding this comment.
Suggested change
| "type: The operation type to search for\n:param " | |
| "type: The operation type to search for\n\n:param " |
There was a problem hiding this comment.
Added this for the return, too.
| "number of operations matching `type`", | ||
| py::arg("type")) | ||
| "type: The operation type to search for\n:param " | ||
| "conditional: if set to true, conditional gates will " |
There was a problem hiding this comment.
I think include_conditional would be a better name.
cqc-alec
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solves #1477
Related issues
Please mention any github issues addressed by this PR.
Checklist