Add convenience method Circuit.add_clexpr_from_logicexp()
#1681
Conversation
cqc-alec
force-pushed
the
ae/clexprle
branch
from
9db39a8
to
09e2fc4
Compare
cqc-alec
changed the title
Circuit.add_clexpr_from_logicexp()
| ":param exp: logical expression\n" | ||
| ":param output_bits: list of bits in output\n" | ||
| ":return: the updated circuit", | ||
| py::arg("exp"), py::arg("output_bits")) |
There was a problem hiding this comment.
| py::arg("exp"), py::arg("output_bits")) | |
| py::arg("exp"), py::arg("output")) |
There was a problem hiding this comment.
And allow sequence[bits] and register?
There was a problem hiding this comment.
I think I prefer output_bits as it is more explicit.
Any sequence of bits should work here.
In principle the output bits do not need to form a register (though that would be the case usually), so I'm not sure it's worth adding an overload.
There was a problem hiding this comment.
I think the question is, would this work, and if not do we want it to?
c = Circuit()
x_reg = c.add_c_register('x', 3)
y_reg = c.add_c_register('y', 3)
z_reg = c.add_c_register('z', 3)
c.add_clexpr_from_logicexp(x_reg | y_reg, z_reg)
There was a problem hiding this comment.
Yes that does work; the register is coerced to a list.
There was a problem hiding this comment.
(ISTR mypy doesn't like it though.)
There was a problem hiding this comment.
Could we add an additional stubs for that, to make mypy happy?
There was a problem hiding this comment.
I'm not sure how to do that?
There was a problem hiding this comment.
I think we would need a second c++ function in the binders for that, but not sure if there might be a easier way?
If you think that is not worth the effort happy to approve this as it is.
There was a problem hiding this comment.
Yeah, I don't think it's worth the effort (and maintenance) of an extra binder just to fix a mypy problem.
No description provided.