Timeout GreedyPauliSimp
#1684
Merged
Timeout GreedyPauliSimp
#1684
+282
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-cqc
reviewed
Nov 19, 2024
Comment on lines
835
to
837
| std::queue< | ||
| std::pair<std::future<Circuit>, std::shared_ptr<std::atomic<bool>>>> | ||
| all_threads; |
| c.decompose_boxes_recursively(); | ||
| circuits.push_back(c); | ||
| } else { | ||
| // If the thread is not ready, move it to the back of the queue |
There was a problem hiding this comment.
Can you elaborate on this comment?
There was a problem hiding this comment.
Ah, it's actually outdated from an earlier version with the multithreading - I can remove it
pytket/binders/transform.cpp
Outdated
| "\n:param timeout: Sets maximum out of time spent finding solution." | ||
| "\n:param thread_timeout: Sets maximum out of time spent finding a " | ||
| "single solution in one thread." | ||
| "\n:param trials: Sets maximum number of found solutions." |
There was a problem hiding this comment.
Maybe explain what qualifies as the best solution?
There was a problem hiding this comment.
Yeah good point, have done
yao-cqc
reviewed
Nov 19, 2024
pytket/binders/transform.cpp
Outdated
Comment on lines
456
to
460
| "\n:param trials: Sets maximum number of found solutions. The " | ||
| "circuit " | ||
| "smallest circuit is returned, priorising the number of 2qb-gates, " | ||
| "then " | ||
| "gates, then depth." |
There was a problem hiding this comment.
Also add this to passes.cpp?
The lines are quite jumbled. The circuit smallest circuit is returned should be The smallest circuit is returned .
|
Still need to update the stubs |
Oops done, sorry forgot to push |
yao-cqc
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
trialsoption toGreedyPauliSimp, running multiple attempts atGreedyPauliSimpand returning the "smallest" circuit.Checklist