Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update YYPhase_using_CX to have fewer U3 #966

Merged
merged 8 commits into from
Aug 14, 2023
Merged

Update YYPhase_using_CX to have fewer U3 #966

merged 8 commits into from
Aug 14, 2023

Conversation

sjdilkes
Copy link
Contributor

No description provided.

@sjdilkes sjdilkes requested a review from cqc-alec August 11, 2023 14:11
cqc-alec
cqc-alec requested changes Aug 11, 2023
View reviewed changes
Copy link
Collaborator

@cqc-alec cqc-alec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, should just update the docstrings in CircPool.hpp and also in the binders (liibrary.cpp).

@sjdilkes sjdilkes requested a review from cqc-alec August 14, 2023 09:46
cqc-alec
cqc-alec requested changes Aug 14, 2023
View reviewed changes
pytket/binders/circuit/library.cpp Outdated Show resolved Hide resolved
tket/include/tket/Circuit/CircPool.hpp Outdated Show resolved Hide resolved
@sjdilkes sjdilkes requested a review from cqc-alec August 14, 2023 13:59
@sjdilkes sjdilkes merged commit 10b02e3 into develop Aug 14, 2023
33 checks passed
@sjdilkes sjdilkes deleted the YYPhase-with-fewer-sq branch August 14, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cqc-alec cqc-alec cqc-alec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjdilkes @cqc-alec