Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build Error and Update Codebase #198

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix Build Error and Update Codebase #198

merged 1 commit into from
Jun 10, 2024

Conversation

PSchmiedmayer
Copy link
Member

Fix Build Error and Update Codebase

♻️ Current situation & Problem

  • Archiving fails due to an older version of ResearchKit and the Firebase SDK

⚙️ Release Notes

  • Updates dependencies and usage of Spezi in the codebase

✅ Testing

  • Only focused on syntactic validity and compiling the code base to be archivable. @sebastianricaldoni & @gperissetcelteeka please verify that this update doesn't effect any elements of the app functionality.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@PSchmiedmayer PSchmiedmayer added the bug Something isn't working label Jun 7, 2024
@PSchmiedmayer PSchmiedmayer self-assigned this Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 4.11%. Comparing base (f14b097) to head (a358cbc).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##            main    #198      +/-   ##
========================================
- Coverage   4.13%   4.11%   -0.01%     
========================================
  Files        133     129       -4     
  Lines      11108   10964     -144     
========================================
- Hits         458     450       -8     
+ Misses     10650   10514     -136     
Files Coverage Δ
Balance/Balance.swift 77.28% <ø> (-0.25%) ⬇️
Balance/BalanceAppDelegate.swift 86.37% <100.00%> (+19.70%) ⬆️
Balance/Diary/Views/DiaryNoteEntryView.swift 0.00% <ø> (ø)
...ction/Gallery/LookVideos/VideoCollectionView.swift 0.00% <ø> (ø)
Balance/Home/Home.swift 0.00% <ø> (ø)
Balance/Login/BalanceAccount.swift 86.96% <ø> (ø)
Balance/Login/InterestingModules.swift 0.00% <ø> (ø)
Balance/Login/LoginView.swift 0.00% <ø> (ø)
Balance/Login/LoginViewLocal.swift 60.27% <ø> (ø)
Balance/Login/SignUpView.swift 0.00% <ø> (ø)
... and 3 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f14b097...a358cbc. Read the comment docs.

Copy link
Collaborator

@sebastianricaldoni sebastianricaldoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌
utACK

@sebastianricaldoni sebastianricaldoni merged commit e2a7001 into main Jun 10, 2024
5 checks passed
@sebastianricaldoni sebastianricaldoni deleted the fix/archive branch June 10, 2024 17:18
gperissetcelteeka added a commit that referenced this pull request Jun 10, 2024
* main:
  Fix Build Error and Update Codebase (#198)
  BAL-194-GP-NEW EVENT TRACKING (#196)

# Conflicts:
#	Balance.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants