Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing hail mary #86

Merged
merged 5 commits into from
Mar 14, 2024
Merged

testing hail mary #86

merged 5 commits into from
Mar 14, 2024

Conversation

zoyagarg
Copy link
Contributor

@zoyagarg zoyagarg commented Mar 14, 2024

Zoya Tests

♻️ Current situation & Problem

Link any open issues or pull requests (PRs) related to this PR. Please ensure that all non-trivial PRs are first tracked and discussed in an existing GitHub issue or discussion.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 40.74074% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 29.63%. Comparing base (319d4b5) to head (e3f381c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
+ Coverage   23.03%   29.63%   +6.61%     
==========================================
  Files          61       61              
  Lines        3713     3733      +20     
==========================================
+ Hits          855     1106     +251     
+ Misses       2858     2627     -231     
Files Coverage Δ
Intake/Allergy Records/AddAllergy.swift 100.00% <100.00%> (+100.00%) ⬆️
Intake/Allergy Records/AllergyRecords.swift 62.91% <100.00%> (+62.91%) ⬆️
Intake/Home.swift 73.89% <75.00%> (-0.24%) ⬇️
Intake/SocialHistory/MenstrualHistory.swift 0.00% <0.00%> (ø)
Intake/SocialHistory/SmokingHistory.swift 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 319d4b5...e3f381c. Read the comment docs.

Copy link
Contributor

@nriedman nriedman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@nriedman nriedman enabled auto-merge (squash) March 14, 2024 20:43
@nriedman nriedman merged commit e8691ca into main Mar 14, 2024
7 checks passed
@nriedman nriedman deleted the pleaseWork branch March 14, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants