Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix app icon #23

Merged
merged 2 commits into from
Feb 22, 2025
Merged

Fix app icon #23

merged 2 commits into from
Feb 22, 2025

Conversation

MiguelAFH
Copy link
Contributor

Name of the PR

♻️ Current situation & Problem

This PR is required to fix the problem with the app icon sizes. In a previous PR the TestFlight integration failed because of this.

⚙️ Release Notes

  • Changed the multi icon option to the single 1024x1024 icon. This makes it easier to manage any icon changes if necessary.

📚 Documentation

This is an important guide to understand app icons.

✅ Testing

None as this is not a code change.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@MiguelAFH MiguelAFH self-assigned this Feb 21, 2025
@MiguelAFH MiguelAFH linked an issue Feb 21, 2025 that may be closed by this pull request
1 task
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.48%. Comparing base (f50169a) to head (c7507a2).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #23       +/-   ##
===========================================
- Coverage   72.02%   61.48%   -10.54%     
===========================================
  Files          26       30        +4     
  Lines         872     1085      +213     
===========================================
+ Hits          628      667       +39     
- Misses        244      418      +174     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c4d709...c7507a2. Read the comment docs.

@MiguelAFH MiguelAFH marked this pull request as ready for review February 21, 2025 20:54
@AdritRao AdritRao enabled auto-merge (squash) February 22, 2025 01:11
@MiguelAFH MiguelAFH requested review from AdritRao and removed request for EthanRakutoBell February 22, 2025 01:11
@AdritRao AdritRao merged commit 389ca1d into main Feb 22, 2025
10 of 11 checks passed
@AdritRao AdritRao deleted the icon branch February 22, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug report: App Icon prevents App from deploying in TestFlight
2 participants