Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background recording functionality #34

Merged
merged 3 commits into from
Mar 4, 2025
Merged

Conversation

EthanRakutoBell
Copy link
Contributor

Enable recording in the background

♻️ Current situation & Problem

Need to ensure that application records and classifies audio in the background, even while the phone screen is off or while the application is closed.

⚙️ Release Notes

Add a bullet point list summary of the feature and possible migration guides if this is a breaking change so this section can be added to the release notes.
Include code snippets that provide examples of the feature implemented or links to the documentation if it appends or changes the public interface.

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

@EthanRakutoBell EthanRakutoBell enabled auto-merge (squash) March 3, 2025 01:57
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 22.91667% with 37 lines in your changes missing coverage. Please review.

Project coverage is 57.65%. Comparing base (f47917c) to head (aee162f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...oughSync/CoughDetection/CoughAnalysisManager.swift 5.27% 18 Missing ⚠️
CoughSync/CoughDetection/CoughClass.swift 25.00% 15 Missing ⚠️
...hSync/CoughDetection/CoughDetectionViewModel.swift 71.43% 2 Missing ⚠️
CoughSync/CoughView/CoughModelView.swift 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   58.87%   57.65%   -1.21%     
==========================================
  Files          32       33       +1     
  Lines        1213     1256      +43     
==========================================
+ Hits          714      724      +10     
- Misses        499      532      +33     
Files with missing lines Coverage Δ
...hSync/CoughDetection/CoughDetectionViewModel.swift 15.39% <71.43%> (+6.88%) ⬆️
CoughSync/CoughView/CoughModelView.swift 0.00% <0.00%> (ø)
CoughSync/CoughDetection/CoughClass.swift 25.00% <25.00%> (ø)
...oughSync/CoughDetection/CoughAnalysisManager.swift 4.73% <5.27%> (+0.22%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47917c...aee162f. Read the comment docs.

Copy link
Contributor

@MiguelAFH MiguelAFH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine overall. Can you document how you tested this works for extended sessions?

@MiguelAFH MiguelAFH self-requested a review March 4, 2025 01:37
@EthanRakutoBell EthanRakutoBell merged commit 029893f into main Mar 4, 2025
9 of 10 checks passed
@EthanRakutoBell EthanRakutoBell deleted the background-recording branch March 4, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants