-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend data type definition & Frontend user input data UI #5
Conversation
2. fix bug in date used when create datatype
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5 +/- ##
===========================================
- Coverage 86.75% 62.67% -24.07%
===========================================
Files 21 26 +5
Lines 709 1042 +333
===========================================
+ Hits 615 653 +38
- Misses 94 389 +295
Continue to review full report in Codecov by Sentry.
|
@dusixian As noted in https://github.com/orgs/CS342/discussions/113#discussioncomment-12051489, ensure that you update all dependencies to the latest version in Xcode and committing all the updated project files + Package.resolved file. You need to run File -> Swift Packages -> Update to Latest Package Versions in Xcode. This might fix your current testing errors. |
merge current main change in to sixian branch
Hi @dusixian, I reviewed your PR, here is my feedback:
|
@mmervecerit Hi Merve! Thanks for your advice. I've changed the eventview and scheduleview following your commits. And for the unit of lab variables, I changed the frontend so the current UI shows the unit when user entry the lab values. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dusixian these were the changes are from the main template Paul pushed, so we should keep them?
Backend data type definition & Frontend user input data UI
♻️ Current situation & Problem
The project requires backend data structures to store manually entered health data and a corresponding frontend UI for users to input these values. This PR introduces data models and a input interface for manual health data entry.
⚙️ Release Notes
Backend Data Type Definitions:
Frontend UI for Manual Data Entry:
📚 Documentation
Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.
✅ Testing
Unit Tests Ensured numeric validation for all manual entry fields (e.g., temperature, blood pressure). Confirmed correct data structure initialization with sample values.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: