GT analysis scripts #167
Open
GT analysis scripts #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blocks whose node examined count increased
Drops into an interpreter even if not run with python -i
Only a good metric for blocks which are fully enumerated both with and without graph transformations.
As GT improve our LB calculation, the relative cost of no GT should be relative to the with-GT lower bound. Otherwise, the "Block Cost - Relative" metric is including the LB improvement, which is misleading.
Applies these fixes: - Teaches validation test about blocks across different passes. Now, if a block was not optimal on a prior pass, the script knows it is not optimal in later passes. - Teaches validation test to handle dags with the same name. Many such examples exist in the benchmark suites that we use. Additionally, a large number of commandline options have been added.
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
56fb83c
to
b5392cb
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
77c55f7
to
f3350b6
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
a1ea719
to
f862b89
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
301922d
to
f4da3b1
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
f4da3b1
to
4aa6d7f
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
3692651
to
b36ad94
Compare
If multiple exist, then we only re-evaluated the heuristic relative to the updated lower bounds after graph transformations, but we didn't actually recompute the heuristic result.
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
b82df24
to
d62e77b
Compare
This reverts commit 35de44c.
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
0205c38
to
5363c47
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
3 times, most recently
from
a542219
to
334325a
Compare
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
334325a
to
da627e1
Compare
Significantly faster than actually parsing
Quincunx271
force-pushed
the
gt-analysis-2.0
branch
from
8529dc3
to
cd0cb39
Compare
Without it, there was no interpreter history. With it, we get Python's interactive interpreter history.
|
This is a massive PR with a lot of changes. It would be reasonable to split this into many smaller PRs if that would make it easier to review. Please tell me if I should go through with that; I don't want to do the work to split it if it's not going to be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds graph transformation analysis scripts. As part of this, several library analysis functions are added.