Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wtc 8 eating #32

Merged
merged 13 commits into from
Feb 1, 2017
Merged

Wtc 8 eating #32

merged 13 commits into from
Feb 1, 2017

Conversation

skibinska
Copy link
Collaborator

@skibinska skibinska commented Feb 1, 2017 •
edited
Loading

fixes #8,

  • add eating page
  • add banana as a slider
  • add checkboxes
  • style slider and checkoxes
  • add logic for slider
  • clean up files

@skibinska skibinska requested a review from des-des February 1, 2017 17:51
des-des
des-des requested changes Feb 1, 2017
View reviewed changes
slider.js Outdated
@@ -0,0 +1,18 @@
//lets populate reel numbers
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrap this up in a function, so you do not pollute global scope!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure 👍

@skibinska skibinska requested a review from des-des February 1, 2017 18:18
@des-des des-des assigned des-des and unassigned skibinska Feb 1, 2017
@des-des des-des merged commit 7e06d8e into master Feb 1, 2017
@des-des des-des deleted the WTC-8-eating branch February 1, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@des-des des-des des-des approved these changes

Assignees

@des-des des-des

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Child user story #5 - eating
2 participants
@skibinska @des-des