Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fetch table with default table #19

Merged
merged 18 commits into from
Oct 9, 2023
Merged

Feature/fetch table with default table #19

merged 18 commits into from
Oct 9, 2023

Conversation

rochamarcelo
Copy link
Contributor

@rochamarcelo rochamarcelo commented Oct 8, 2023 •
edited
Loading

  • Check defined $defaultTable when calling LocatorAwareTrait::fetchTable without arguments
  • For controllers when calling fetchTable without arguments and not defined custom $defaultTable try to detect the table based on the Controller's className
  • Fixed console helper extension to use ucfirst as is done in the method ConsoleIo::helper
  • phpcs fixes
  • phpstan fixes

@rochamarcelo rochamarcelo mentioned this pull request Oct 8, 2023
Closed
@rochamarcelo
Check table based on the controller className when calling LocatorAwa…
a3a777d 
…reTrait::fetchTable without arguments
@rochamarcelo
Check table based on the controller className when calling LocatorAwa…
588ad47 
…reTrait::fetchTable without arguments
@rochamarcelo
Check table based on the controller className when calling LocatorAwa…
4dc4048 
…reTrait::fetchTable without arguments
@rochamarcelo
phpqa fixes
2c710a7
@rochamarcelo
phpqa fixes
b02f0a3
@rochamarcelo
Fix reference issues when fetchTable is called inside other class usi…
018c2c6 
…ng property or var, ex: `$this->MyClass->SecondClass->fetchTable()`. Refactoring code.
@rochamarcelo
Refactoring code
3d46dda
@rochamarcelo
Refactoring code
b00eb0f
@rochamarcelo
Refactoring codex
19fb294
@rochamarcelo
Used debug flag for phpstan and ignore errors related to generic obje…
1ebe90c 
…ct type(ex: ReflectionClass)
@rochamarcelo
fixing phpunit issue.
3d16626
@rochamarcelo
fixing phpunit issue.
44e98e7
@rochamarcelo
phpstan integration on ci
d87e73a
@steinkel steinkel merged commit 91f6c0c into 3.next-cake5 Oct 9, 2023
4 checks passed
@rochamarcelo rochamarcelo deleted the feature/fetch-table-with-default-table branch October 10, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steinkel steinkel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rochamarcelo @steinkel