Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIREFLY-674: Add custom Online-Help feature to API #1035

Merged
merged 1 commit into from
Oct 21, 2020

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Oct 20, 2020

https://jira.ipac.caltech.edu/browse/FIREFLY-674

Allow API user to set custom location of Online-Help. To test, goto Test URL below and scroll down to test #5.
Click on the Help icon(?) at upper right side of the table. Click on source: show to see how it's done.

Test: https://fireflydev.ipac.caltech.edu/firefly-674-help-base-url-api/firefly/test/tests-main.html#test-5

@loitly loitly requested a review from ejoliet October 20, 2020 18:18
@loitly loitly self-assigned this Oct 20, 2020
@loitly loitly force-pushed the FIREFLY-674_help_base_url_api branch from 47f17a1 to d10006a Compare October 20, 2020 18:34
@loitly loitly force-pushed the FIREFLY-674_help_base_url_api branch from d10006a to dc190b1 Compare October 20, 2020 18:46
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and works as described.
The code change required in the HTML code is minimum.
That's pretty much what Firefly-based HTML pages would need to overwrite the default base URL to a specific one.

Thanks!

@loitly loitly merged commit 1eee2f3 into dev Oct 21, 2020
@loitly loitly deleted the FIREFLY-674_help_base_url_api branch October 21, 2020 16:45
@robyww robyww added this to the 2020.3 milestone Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants