Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefly 1420 cleanup items #1505

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Firefly 1420 cleanup items #1505

merged 5 commits into from
Feb 29, 2024

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Feb 28, 2024

Ticket: https://jira.ipac.caltech.edu/browse/FIREFLY-1420

Converted DialogRootContainer.DropDown to JoyUI Dropdown.
Converted View As Text popup
Added Stacker container

Also worked on issues from: https://confluence.ipac.caltech.edu/pages/viewpage.action?pageId=674536199

  • 4: Too much padding in table Headers
  • 13:Image Search: move expand icon next to dataset label
  • 21: size of the save table pop-up is not big enough
  • 22: revert to checkboxes
  • 23: use old add column icon. does not support dark mode

Test: https://fireflydev.ipac.caltech.edu/firefly-1420-cleanup-items/firefly

@loitly loitly added the UI Client side UI changes not related to any of the visualizers label Feb 28, 2024
@loitly loitly requested a review from robyww February 28, 2024 00:21
@loitly loitly self-assigned this Feb 28, 2024
@robyww robyww requested a review from lrebull February 28, 2024 15:45
@robyww robyww added this to the UI-conversion milestone Feb 28, 2024
@lrebull
Copy link
Contributor

lrebull commented Feb 28, 2024

Ok, i'm trying ...
item 4 talks about table headers/widths. the example given is in DCE. the build above is just firefly. Ok, fine; i went to ops and got a table from DCE (attached), and tried to upload it to the firefly build above. I get:

Table Load Error:
java.lang.RuntimeException: Type mismatch(false): expecting class java.lang.Boolean but found class java.lang.String

help?

table_IRIS-Images-1.tbl.gz

@lrebull
Copy link
Contributor

lrebull commented Feb 28, 2024

NEVERMIND (strikethrough)Item 13 is an IRSA Viewer thing, but i only have a firefly build to test. so i'm stuck here too.(/strikethrough)
I am just not awake yet. One can see this in the images tab even in firefly. this is better than it was!

@lrebull
Copy link
Contributor

lrebull commented Feb 28, 2024

#21 is fixed!
#22 is fixed!
#23 is using old icon and i think it looks ok in dark mode..?

@robyww
Copy link
Contributor

robyww commented Feb 28, 2024

@Loi for the table headers issue: Some are too narrow. (tap, m1, 100 arcsec, all else default)
Screenshot 2024-02-28 at 10 47 00 AM

@lrebull
Copy link
Contributor

lrebull commented Feb 28, 2024

At Trey's suggestion, tried a TAP search in this build. Now some of the headers are way too narrow. See screenshot.
Screenshot 2024-02-28 at 9 49 23 AM

(ooh, crossed comments!)

@loitly
Copy link
Contributor Author

loitly commented Feb 28, 2024

@lrebull @robyww, IRSA TAP is a bad choice for testing item 4. IRSA returns table with attribute width="5" in their FIELDs. Firefly will use that value to set the default width when given. You can see this in OPS as well.

@loitly loitly force-pushed the FIREFLY-1420_cleanup_items branch from 1121081 to 9b83472 Compare February 29, 2024 21:46
@loitly loitly merged commit b941c25 into dev Feb 29, 2024
@loitly loitly deleted the FIREFLY-1420_cleanup_items branch March 1, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI Client side UI changes not related to any of the visualizers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants