Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRSA-6536: SPHEREx Photometry tool job submission UI #1686

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

jaladh-singhal
Copy link
Member

@jaladh-singhal jaladh-singhal commented Dec 24, 2024

Fixes IRSA-6536

See ife PR: https://github.com/IPAC-SW/irsa-ife/pull/372

  • Generalize wavelength options in a new component that can be used outside obsCore TAP context
    • Also tried to standardize names among field keys and slotProps for different subcomponents
  • Made EmbeddedPositionSearchPanel to work when only cone and upload is on
    • refactored the toggle options generation code since the logic didn't use to account for that case

Testing

Do regression testing if Wavelength Panel in ObsCore TAP searches is working as before: https://fireflydev.ipac.caltech.edu/irsa-6536-specphoto-ui/firefly

Do regression testing of EmbeddedSearchPosition Panel in:

@jaladh-singhal jaladh-singhal self-assigned this Dec 24, 2024
@robyww robyww added this to the 2025.2 milestone Jan 13, 2025
Comment on lines +124 to +126
const [getSelectionType,] = useFieldGroupValue(fieldKeys.selectionType);
const [getRangeType,] = useFieldGroupValue(fieldKeys.rangeType);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you don't need the , comma

Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks better than before.

IRSA-6536: Use wavelength options out of TAP context

IRSA-6536: Expose field key names of Wavelength options

IRSA-6536: Improve layout and fix console errors

IRSA-6536: Replace cone, polygon option with single-object
@jaladh-singhal jaladh-singhal merged commit 8b24020 into dev Feb 4, 2025
@jaladh-singhal jaladh-singhal deleted the IRSA-6536-specphoto-ui branch February 4, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants