DM-4484: Catalogs Overlay #44
Conversation
Also the following: - Introduction of Sagas - fixed TargetPanel bug - added forceReinit property to FieldGroup components - added z-index for dialogs
| return; | ||
| } | ||
|
|
||
| const params= { |
There was a problem hiding this comment.
Here you might want to specify "decimate" parameter to handle large catalogs:
decimate: serializeDecimateInfo(columns.lonCol, columns.lonCol.latCol, numPoints [,limits])
The helper function is in Decimate.js
|
OK, I've got basic idea of how you use sagas. Though I should say generators are mind twisting. (Hopefully, we'll get used to them.) One thing I noticed: When I bring another image and another catalog, the highlighted row is not reflected in the catalog, even though clicking on a point seems to change it. |
Once you do get your head around generators these sagas really simplify the flow. Everything become really straight forward. I am really excited about them. |
|
I am already working on part two of the ticket (DM-4503). I will fix the bug and add the decimate in that one. |
| case DataTypes.SELECTED_IDX_ARY: | ||
| return null; | ||
| break; | ||
| } |
There was a problem hiding this comment.
I think the "break" is not needed here.
There was a problem hiding this comment.
your right, in this case none of them are needed.
There was a problem hiding this comment.
Do we want to return null or throw an exception so it can be re-thrown and trace upfront? Or do we handle the 'null' on the component view after dispatch?
There was a problem hiding this comment.
The way the getDrawData is made it supports nulls. However, the next ticket (the one I am working on now) we will support selected.
| canFilter: true, | ||
| helpLine : helpText, | ||
| canUserChangeColor: ColorChangeType.STATIC | ||
| }; |
There was a problem hiding this comment.
One improvement we should add here (or to a different ticket) is that the user should be able to change the shape and size of the overlay symbol
There was a problem hiding this comment.
That would be pretty easy to do. More work in the UI than anything else.
Catalogs Overlay
Also the following: