Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-14867, IRSA-2466: fixed bugs in tickets #724

Merged
merged 1 commit into from
Jan 17, 2019
Merged

Conversation

robyww
Copy link
Contributor

@robyww robyww commented Jan 16, 2019

DM-14867, IRSA-2466: fixed bugs in tickets

- IRSA-2466: Only HiPS or AllSky FITS will recenter when table tabs switch
- DM-14867: Toolbar button and then "Select new Image" buttons is active when image plot fails in API
- API UI Test framework modified to allows for resizing the IFrames

To Test:

DM-14867:

IRSA-2466:

  • http://localhost:8080/firefly
  • load 1 or more fits images at m31
  • load 1 or more HiPS at m31
  • goto catalogs and load two catalogs. 100 arcsec, 2mass and wise at m31
  • scroll the FITS and HIPS away from the current center
  • switch table table tabs
  • The HiPS should recenter the FITS (non-allsky) should not.

Testing Frame work:

  • Notice that each test can be resized now.

@robyww robyww self-assigned this Jan 16, 2019
@robyww robyww requested a review from loitly January 16, 2019 23:22
Copy link
Contributor

@loitly loitly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Bonus points for adding not only one but 2 tests into the code base. Bravo!

    - IRSA-2466: Only HiPS or AllSky FITS will recenter when table tabs switch
    - DM-14867: Toolbar button and then "Select new Image" buttons is active when image plot fails in API
    - API UI Test framework modified to allows for resizing the IFrames
@robyww robyww force-pushed the dm-14867-irsa-2466-bug-fixes branch from 0095bcd to 8a6722b Compare January 17, 2019 17:23
@robyww robyww merged commit 572caf3 into dev Jan 17, 2019
@robyww robyww deleted the dm-14867-irsa-2466-bug-fixes branch February 27, 2019 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants