Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIREFLY-137: add additional information into the row highlight action #939

Merged
merged 1 commit into from
Feb 29, 2020

Conversation

loitly
Copy link
Contributor

@loitly loitly commented Feb 27, 2020

https://jira.ipac.caltech.edu/browse/FIREFLY-137
From ticket:

  • one or more columns' values or the entire row
  • the "absolute row index" of the row in the table (i.e., an index that refers to the same row no matter how the filter or sort state of the table may have changed)
  • the relative index of the row in the currently displayed content of the table
  • the checkbox state of the row

Also:

  • added test case to demonstrate how to listen to table events
  • add feature copy source to clipboard to integrated test framework

Best to see this in action. Test case #4
https://irsawebdev9.ipac.caltech.edu/FIREFLY-137_table_highlight_info/firefly/test/tests-table.html#4

- added test case to demonstrate how to listen to table events
- add feature copy source to clipboard
@loitly loitly added the API label Feb 27, 2020
@loitly loitly requested a review from ejoliet February 27, 2020 18:20
@loitly loitly self-assigned this Feb 27, 2020
Copy link
Contributor

@ejoliet ejoliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that the row index is added.
Nice 'copy' feature on the tests pages.
Thanks!

@robyww robyww added this to the 2020.1 milestone Feb 28, 2020
@loitly loitly merged commit f766841 into dev Feb 29, 2020
@loitly loitly deleted the FIREFLY-137_table_highlight_info branch February 29, 2020 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants