Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: multiple screen selection #118

Merged

Conversation

5war00p
Copy link
Contributor

@5war00p 5war00p commented Oct 11, 2024

Contains rust and typescript file changes w.r.to Multi screen selection.

/claim #114

Copy link

vercel bot commented Oct 11, 2024

@5war00p is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@5war00p
Copy link
Contributor Author

5war00p commented Oct 11, 2024

/claim #114

@richiemcilroy
Copy link
Collaborator

Hey @5war00p - tested this out and even though I can see the two different screens in the screen selector - no matter what one I pick, it always records my Macbook screen, not the monitor. Switched between extended mode / screen mirroring. Also, can you change the labels (e.g. Screen 1, Screen 2), to the actual monitor / screen names?

Also, if there's only 1 screen selected, don't allow the option to click select.

@5war00p
Copy link
Contributor Author

5war00p commented Oct 12, 2024

Hey @5war00p - tested this out and even though I can see the two different screens in the screen selector - no matter what one I pick, it always records my Macbook screen, not the monitor. Switched between extended mode / screen mirroring. Also, can you change the labels (e.g. Screen 1, Screen 2), to the actual monitor / screen names?

Also, if there's only 1 screen selected, don't allow the option to click select.

I see me change those conditions for name, I don't think if we get names for screens, but will check that up.

Also the IDs of the screens, looks screen IDs not coming accurately.

Will debug it.

@5war00p
Copy link
Contributor Author

5war00p commented Oct 12, 2024

image

@richiemcilroy I've updated it

@5war00p
Copy link
Contributor Author

5war00p commented Oct 17, 2024

@richiemcilroy Did checked this again? I see there are lot of changes, and I resolved conflicts as well

- use separate target selects
- display monitor names instead of indexes
- provide proper target to scap
@Brendonovich Brendonovich merged commit 1ac5ee4 into CapSoftware:main Oct 22, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants