Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modeling_base): re-order model.forward_kwargs initialization #566

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

maxreciprocate
Copy link
Collaborator

@maxreciprocate maxreciprocate commented Oct 16, 2023

Fix of #564, #567

This PR initializes model.forward_kwargs after PEFT wrapper initialization. Previously it was stuck into model.post_init which was never executed under PEFT.

W&B run

@codecov-commenter
Copy link

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bcd237f) 43.53% compared to head (bbd8208) 43.50%.

❗ Current head bbd8208 differs from pull request most recent head fac85dd. Consider uploading reports for the commit fac85dd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #566      +/-   ##
==========================================
- Coverage   43.53%   43.50%   -0.04%     
==========================================
  Files          33       33              
  Lines        4989     4986       -3     
==========================================
- Hits         2172     2169       -3     
  Misses       2817     2817              
Files Coverage Δ
trlx/models/modeling_base.py 72.90% <83.33%> (-0.52%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxreciprocate maxreciprocate merged commit d03fea7 into main Oct 17, 2023
2 checks passed
@maxreciprocate maxreciprocate deleted the fix-peft-forward-kwargs branch October 17, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants