Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Switch 컴포넌트 추가 #11

Merged
merged 5 commits into from
Jan 17, 2025
Merged

feat: Switch 컴포넌트 추가 #11

merged 5 commits into from
Jan 17, 2025

Conversation

DongjaJ
Copy link
Collaborator

@DongjaJ DongjaJ commented Jan 16, 2025

이슈 번호

  • close #이슈_번호

작업한 목록을 작성해 주세요

  • Switch 컴포넌트를 추가했어요.

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • 처음에는 Radix의 Switch 컴포넌트를 이용해 check, onCheckChange를 이용해서 관리하려고 했어요.
  • 그런데 switch 상태가 check 인지 아닌지 보다 각각의 value가 있는 것 같아서 Radix의 ToggleGroup으로 구현을 변경했습니다.
  • 그런데 만들고 보니까 ToggleGroup으로 만든거는 약간의 버그가 있어서 일단 Switch를 이용해서 만든 컴포넌트도 남겨놨습니다.
  • Switch Component를 한번 Wrapping해서 check 여부를 string으로 관리할 수 있게 했습니다.

연관된 issue: #9

@DongjaJ DongjaJ requested a review from ptq124 as a code owner January 16, 2025 08:28
@DongjaJ DongjaJ linked an issue Jan 16, 2025 that may be closed by this pull request
1 task
@github-actions github-actions bot added the fix label Jan 16, 2025
Copy link
Collaborator

@ptq124 ptq124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 잘 만드셨네용!

@DongjaJ DongjaJ merged commit 8339a50 into main Jan 17, 2025
3 checks passed
@DongjaJ DongjaJ deleted the feat-9 branch January 17, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: switch pill
2 participants