Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: color 적용안되는 문제 해결 #13

Merged
merged 2 commits into from
Jan 16, 2025
Merged

bug: color 적용안되는 문제 해결 #13

merged 2 commits into from
Jan 16, 2025

Conversation

ptq124
Copy link
Collaborator

@ptq124 ptq124 commented Jan 16, 2025 •
edited by github-actions bot
Loading

이슈 번호

작업한 목록을 작성해 주세요

  • 기존 style 객체 값에서, globalVars 객체에 직접 접근하도록 수정했습니다. 이제 recipe 적용 될거에요.

스크린샷

pr 포인트나 궁금한 점을 작성해 주세요

  • color와 background 함수를 각각 나누면 코드 중복이 발생되어서, color, background 프로퍼티를 만들어서 사용할지 아니면 그냥 하나로 할지 고민해봤는데, 이미 recipe에서 배경과 색을 구분지어놔서 color로만 가도 될거 같아요~

연관된 issue: #12

@ptq124 ptq124 requested a review from DongjaJ as a code owner January 16, 2025 10:39
@github-actions github-actions bot added bug Something isn't working chore fix labels Jan 16, 2025
DongjaJ
DongjaJ approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@DongjaJ DongjaJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다~ 고생하셨어요

@ptq124 ptq124 merged commit 72c4975 into main Jan 16, 2025
4 checks passed
@ptq124 ptq124 deleted the bug-12 branch January 16, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DongjaJ DongjaJ DongjaJ approved these changes

Assignees

@ptq124 ptq124

Labels
bug Something isn't working chore fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: color, background 적용 안되는 문제 해결
2 participants
@ptq124 @DongjaJ