fix: use larger operand type as binop result type #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckki
suggested changes
Jul 25, 2023
|
Otherwise, I confirmed this PR (along with the companion PR) fixed the crash. |
duckki
approved these changes
Jul 26, 2023
kevinclancy
added a commit
that referenced
this pull request
Jul 28, 2023
* when binop operand types have different sizes, use the larger one for the result * when types of left and right operand have the same size, use the left one https://github.com/CertiKProject/slither-task/issues/644
whonore
pushed a commit
that referenced
this pull request
May 24, 2024
* when binop operand types have different sizes, use the larger one for the result * when types of left and right operand have the same size, use the left one https://github.com/CertiKProject/slither-task/issues/644
whonore
pushed a commit
that referenced
this pull request
May 24, 2024
* when binop operand types have different sizes, use the larger one for the result * when types of left and right operand have the same size, use the left one https://github.com/CertiKProject/slither-task/issues/644
whonore
pushed a commit
that referenced
this pull request
May 28, 2024
* when binop operand types have different sizes, use the larger one for the result * when types of left and right operand have the same size, use the left one https://github.com/CertiKProject/slither-task/issues/644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This fixes issue 644, which is that the type of the left hand operand is used in a binary operation, even though the larger operand type should be used in the case of integer types.
A better approach would be to insert an explicit cast from the smaller type to the larger type, as noted here. However, the current PR's approach is easier and works, as far as I know.
Testing
Related Issue
https://github.com/CertiKProject/slither-task/issues/644