Pin earcut version

[jjspace]

Description

Version 3.0.0 of earcut dropped support for CommonJS however CesiumJS still supports using it as a CommonJS module. This PR pins the version at 2.2.4 for now for compatibility.

Opened #12411 to track updating this in the future

This was the reported cause of #12294

Issue number and link

Fixes #12294

Testing plan

1. npm install to update packages
2. Restart the local server if it's already running, it may not pick up the new npm packages otherwise
3. Download district.json as provided in this comment and put it in Apps/SampleData
4. Open this sandcastle
5. Ensure that it loads and displays the internal polygon correctly.

Author checklist

• I have submitted a Contributor License Agreement
• I have added my name to CONTRIBUTORS.md
• I have updated CHANGES.md with a short summary of my change
• I have added or updated unit tests to ensure consistent code coverage
• I have updated the inline documentation, and included code examples where relevant
• I have performed a self-review of my code

[github-actions]

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

[ggetz]

Thanks for looking into this @jjspace!

I've asked @ArgentumHHH for a Sandcastle example so we can verify this fix.

[ggetz]

I haven't been able to track down code to reproduce #12294.

@jjspace Are you sure earcut dropping CommonJS is the source of this issue? We use earcut only in our (ESM) source code where it then gets built into a worker.

[ggetz]

@jjspace any thoughts on my comment above?

[jjspace]

Are you sure earcut dropping CommonJS is the source of this issue? We use earcut only in our (ESM) source code where it then gets built into a worker.

@ggetz I am not positive, I just opened the PR quick because it seemed to be the highlighted cause and I saw it swapped to ESM only. I was hoping we could get a good sample to verify.

I was under the assumption we wanted to avoid ESM only modules because we still support CommonJS. We've had issues with that in the past. I did not look closely at where this is used so if this packages is not one we have to care about I think this PR can just be closed.

[jjspace]

@ggetz, @ArgentumHHH has provided a sample file and I can now confirm this change does fix the issue. I've updated the testing plan with a link to a local sandcastle to demonstrate.